Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ndusart/cppcodec
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: tplgy/cppcodec
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 15 commits
  • 10 files changed
  • 6 contributors

Commits on Aug 8, 2018

  1. cast int const to alphabet_index_t type

    clang fail to build without this static_cast
    ndusart committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    4bc857c View commit details
    Browse the repository at this point in the history
  2. Merge pull request tplgy#54 from ndusart/cast

    cast int const to alphabet_index_t type
    jpetso authored Aug 8, 2018
    Configuration menu
    Copy the full SHA
    661f149 View commit details
    Browse the repository at this point in the history
  3. Update Catch to v2.3.0.

    This changes the include path from <catch.hpp> to <catch2/catch.hpp>,
    and gets rid of all remaining warnings on VS2017.
    (VS2015 still emits a bunch of questionable warnings.)
    jpetso committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    b9e3bba View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2018

  1. Merge pull request tplgy#55 from jpetso/master

    Update Catch to v2.3.0.
    jpetso authored Aug 20, 2018
    Configuration menu
    Copy the full SHA
    302dc28 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2018

  1. Fix tplgy#62

    <Windows.h> includes macro definitions named max and min, wrap the call to max and min with parentheses, which prevent the macro expansion
    Gabriele_Frau committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    9f67d70 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2018

  1. Merge pull request tplgy#63 from GabrieleFrau/master

    Fix tplgy#62 - compile error when including <Windows.h> due to macro expansion
    jpetso authored Oct 18, 2018
    Configuration menu
    Copy the full SHA
    82d0117 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2018

  1. Fix comment referring to the wrong RFC encoding

    This is "Base 32 Encoding with Extended Hex Alphabet"
    jbzdarkid authored Nov 12, 2018
    Configuration menu
    Copy the full SHA
    793a427 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2018

  1. Merge pull request tplgy#64 from jbzdarkid/patch-1

    Fix comment referring to the wrong RFC encoding
    jpetso authored Nov 14, 2018
    Configuration menu
    Copy the full SHA
    26ae528 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2018

  1. Fix tplgy#59: Unreachable code warning in the padder class.

    By taking the padding character put call out of the tail() function
    and appending it after the tail() call in encode(), the compiler
    will work with a more limited set of numbers known at runtime
    instead of a slightly longer list of consecutive numbers at
    compile time. The code paths that would cause an unreachable code
    warning are now actually removed and would also be impossible
    to tell in advance by the compiler.
    
    Code sizes remain the same for clang as well as gcc in all
    but debug builds, where they only marginally differ.
    
    What's weird is that this change makes my GCC 8.2 release build
    perform better on the "Decoding to vector<uint8_t>" benchmark -
    weird because none of the changed code is called by any decode()
    code paths. But hey, I'll take it. Average time for this task
    go down from approx. 67 microseconds for the size 32768 buffer
    to approx. 54 microseconds on my machine. Clang appears unaffected.
    jpetso committed Nov 25, 2018
    Configuration menu
    Copy the full SHA
    d3cab2d View commit details
    Browse the repository at this point in the history
  2. Add CPPCODEC_ALWAYS_INLINE statements to raw_result_buffer.

    This should make sure it doesn't suffer from unnecessary slowness.
    The good news is that GCC and Clang release builds don't seem to
    be noticeably affected by this change, they must have already
    done the right thing (inlining) beforehand. Nonetheless, compilers
    with less predictive skill may get a speed-up from this.
    
    Also, remove raw_result_buffer::last() because it's not needed
    and makes it look like it's necessary for data wrappers, which
    it's not.
    jpetso committed Nov 25, 2018
    Configuration menu
    Copy the full SHA
    322e526 View commit details
    Browse the repository at this point in the history
  3. Merge pull request tplgy#65 from jpetso/master

    Fix a recent warning and ensure inlining for less-smart compilers.
    jpetso authored Nov 25, 2018
    Configuration menu
    Copy the full SHA
    bd6ddf9 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. added contents section to readme (tplgy#72)

    ph3b3 authored Jun 30, 2021
    Configuration menu
    Copy the full SHA
    9838f9e View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2022

  1. Allow using cppcodec as a CMake dependency

    This makes CMakeLists.txt suitable for inclusion into a
    parent CMake project via add_subdirectory() command,
    and defines the "cppcodec" target as INTERFACE library.
    Use it in a target_link_libraries() command as dependency
    in order to add cppcodec's include directories to your target.
    
    The minimum CMake requirement is now 3.13, picking up various
    improvements to INTERFACE library targets and avoiding any
    confusion around CMake policy CMP0076, a behavior changed in 3.13.
    
    The CMake build will now build tests, examples and tools if built
    stand-alone, but exclude them if built as part of another project.
    This can be customized via CPPCODEC_BUILD_{TESTING,EXAMPLES,TOOLS}
    CMake definitions for a given build.
    
    Fixes tplgy#60
    Fixes tplgy#61
    
    This commit is based on changes by Quintz Gábor (@quiga on GitHub),
    but modified and extended in a number of ways.
    
    Thanks also to Aditya Gupta (@adi-g15), anonymous @ghuser404
    and Kingsley Chen (@kingsamchen) for keeping this issue on
    my radar and providing valuable feedback.
    jpetso committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    2757213 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2053efc View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Merge pull request tplgy#76 from jpetso/modern-cmake

    Allow using cppcodec as a CMake dependency
    jpetso authored Sep 6, 2022
    Configuration menu
    Copy the full SHA
    8019b8b View commit details
    Browse the repository at this point in the history
Loading