[LINT] error 438

Last value assigned to variable 'Symbol' not used

Signed-off-by: Jocelyn Legault <jocelynlegault@gmail.com>

Author: joce

PythonScript/src/ProcessExecute.cpp

@@ -281,24 +281,19 @@ DWORD WINAPI ProcessExecute::pipeReader(void *args)
 
 	DWORD bytesRead;
 
-	
 	char buffer[PIPE_READBUFSIZE];
 	BOOL processFinished = FALSE;
-	BOOL dataFinished = FALSE;
 	int handleIndex;
 
-	while(!dataFinished)
+	for(;;)
 	{
 		::PeekNamedPipe(pipeReaderArgs->hPipeRead, NULL, 0, NULL, &bytesRead, NULL);
 
 		if (processFinished && 0 == bytesRead)
 		{
-			dataFinished = TRUE;
 			break;
 		}
 
-
-
 		if (bytesRead > 0)
 		{
 			if (ReadFile(pipeReaderArgs->hPipeRead, buffer, PIPE_READBUFSIZE - 1, &bytesRead, NULL))
@@ -330,8 +325,6 @@ DWORD WINAPI ProcessExecute::pipeReader(void *args)
 					break;
 			}
 		}
-
-		
 	}
 
 	CloseHandle(pipeReaderArgs->hPipeRead);

PythonScript/src/PyProducerConsumer.h

@@ -123,8 +123,7 @@ void PyProducerConsumer<DataT>::consumer()
 {
 	HANDLE waitHandles[] = {m_dataAvailable, m_shutdown};
 	bool queueEmpty;
-	bool shutdownSignalled = false;
-	while(!shutdownSignalled)
+	for(;;)
 	{
 
 		DWORD waitResult = WaitForMultipleObjects(2, waitHandles, false, INFINITE);
@@ -134,9 +133,6 @@ void PyProducerConsumer<DataT>::consumer()
 			// Shutdown immediately
 			// An alternative would be to "finish up" the queue
 			// but we don't want to do that in PyScript - just close N++
-			// This is set to avoid the C4127 conditional expression constant warning if 
-			// we use while(true)
-			shutdownSignalled = true;
 			break;
 		}
 		m_consuming = true;