Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: smarr/ReBench
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: smarr/ReBench
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: use-subprocess32
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 10 files changed
  • 2 contributors

Commits on Jan 5, 2020

  1. Robustify subprocess handling 

    Python from 3.2 on support timeouts on subprocesses directly
subprocess32 backports that to Python 2

Signed-off-by: Stefan Marr <git@stefan-marr.de>

# Conflicts:
#	rebench/configurator.py
#	rebench/executor.py
#	setup.py
    @krono @smarr
    krono authored and smarr committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    291c27b View commit details
    Browse the repository at this point in the history

  2. Code defaults via default parameters. 

    Easier to read. Also, `timeout=None` because that's what modern
subprocess expects
    @krono @smarr
    krono authored and smarr committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    84bd682 View commit details
    Browse the repository at this point in the history

  3. utilize humanfriendly where it helps

    @krono @smarr
    krono authored and smarr committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    8dd3c90 View commit details
    Browse the repository at this point in the history

  4. make sure we have a thread

    @krono @smarr
    krono authored and smarr committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    dd63a01 View commit details
    Browse the repository at this point in the history

  5. Fix import 

    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    @smarr
    smarr committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    b61feac View commit details
    Browse the repository at this point in the history

  6. Fix pylint 

    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    @smarr
    smarr committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    226b8fc View commit details
    Browse the repository at this point in the history
Loading