Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: wbluke/readable-code
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: sion-running/readable-code
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 17 commits
  • 19 files changed
  • 1 contributor

Commits on Sep 30, 2024

  1. 섹션2 추상: 의미있는 이름으로 변수명 변경

    @sion-running
    sion-running committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c4681af View commit details
    Browse the repository at this point in the history

  2. 섹션2 추상: 하나의 기능 단위로 메서드 추출하기

    @sion-running
    sion-running committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    cb299ba View commit details
    Browse the repository at this point in the history

  3. 섹션2 추상: 구체화된 레벨의 코드들을 메서드로 분리

    @sion-running
    sion-running committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e5ca24a View commit details
    Browse the repository at this point in the history

  4. 섹션2 추상: 매직 넘버, 매직 스트링을 상수로 분리하기

    @sion-running
    sion-running committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    52612f5 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. 섹션3: 해피 케이스와 예외 처리

    @sion-running
    sion-running committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    76c0351 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2025

  1. 도메인 분리하기

    @sion-running
    sion-running committed Jan 26, 2025
    Configuration menu
    Copy the full SHA
    04d6942 View commit details
    Browse the repository at this point in the history

  2. 입/출력 역할을 담당하는 클래스 분리

    @sion-running
    sion-running committed Jan 26, 2025
    Configuration menu
    Copy the full SHA
    90f9382 View commit details
    Browse the repository at this point in the history

  3. 역할을 더 잘 드러내도록 클래스 네이밍 변경

    @sion-running
    sion-running committed Jan 26, 2025
    Configuration menu
    Copy the full SHA
    6012a72 View commit details
    Browse the repository at this point in the history

  4. 변경한 exception 네이밍 적용

    @sion-running
    sion-running committed Jan 26, 2025
    Configuration menu
    Copy the full SHA
    b356f54 View commit details
    Browse the repository at this point in the history

  5. BOARD 상수를 클래스로 분리하고, 관련된 책임들을 board 내부 메소드에게 위임하도록 변경

    @sion-running
    sion-running committed Jan 26, 2025
    Configuration menu
    Copy the full SHA
    1be5527 View commit details
    Browse the repository at this point in the history

  6. row, col이 두자리수 일 때도 게임 테이블을 보여줄 수 있도록 수정

    @sion-running
    sion-running committed Jan 26, 2025
    Configuration menu
    Copy the full SHA
    939f9cd View commit details
    Browse the repository at this point in the history

  7. level 관련 인터페이스를 생성하고, 런타임시 레벨 지정하도록 개선

    @sion-running
    sion-running committed Jan 26, 2025
    Configuration menu
    Copy the full SHA
    3278d59 View commit details
    Browse the repository at this point in the history

  8. Cell의 추상클래스를 만들고, Cell 타입별 자식 클래스 생성

    @sion-running
    sion-running committed Jan 26, 2025
    Configuration menu
    Copy the full SHA
    e8b5833 View commit details
    Browse the repository at this point in the history

  9. LSP를 준수하도록 상속구조 개선

    @sion-running
    sion-running committed Jan 26, 2025
    Configuration menu
    Copy the full SHA
    47cbcfb View commit details
    Browse the repository at this point in the history

  10. ISP 학습: Game 인터페이스 생성

    @sion-running
    sion-running committed Jan 26, 2025
    Configuration menu
    Copy the full SHA
    84fec5f View commit details
    Browse the repository at this point in the history

  11. ISP 학습: 하나의 인터페이스가 하나의 책임으로 구성되도록, 기능별 인터페이스 분리

    @sion-running
    sion-running committed Jan 26, 2025
    Configuration menu
    Copy the full SHA
    bc243ac View commit details
    Browse the repository at this point in the history

  12. game 패키지 분리, 학습용으로 생성한 클래스 삭제

    @sion-running
    sion-running committed Jan 26, 2025
    Configuration menu
    Copy the full SHA
    9568c5c View commit details
    Browse the repository at this point in the history
Loading