Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ryanpetrello/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 2 files changed
  • 1 contributor

Commits on May 20, 2011

  1. Fixing a bug in url.parse: #562 

    The file:// protocol *always* has a hostname; it's frequently abbreviated as
an empty string, which represents 'localhost' implicitly.

According to RFC 1738 (http://tools.ietf.org/html/rfc1738):

A file URL takes the form:

   file://<host>/<path>

where <host> is the fully qualified domain name of the system on
which the <path> is accessible...

As a special case, <host> can be the string "localhost" or the empty
string; this is interpreted as `the machine from which the URL is
being interpreted'.
    @ryanpetrello
    ryanpetrello committed May 20, 2011
    Configuration menu
    Copy the full SHA
    2c96e2d View commit details
    Browse the repository at this point in the history

  2. Improving a unit test for url.parse.

    @ryanpetrello
    ryanpetrello committed May 20, 2011
    Configuration menu
    Copy the full SHA
    34b29b8 View commit details
    Browse the repository at this point in the history

  3. Revert "Improving a unit test for url.parse." 

    This reverts commit 34b29b8.
    @ryanpetrello
    ryanpetrello committed May 20, 2011
    Configuration menu
    Copy the full SHA
    3a4a029 View commit details
    Browse the repository at this point in the history

  4. Improved unit tests for url.parse's handling of file://

    @ryanpetrello
    ryanpetrello committed May 20, 2011
    Configuration menu
    Copy the full SHA
    e4cdf83 View commit details
    Browse the repository at this point in the history
Loading