Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Alir3z4/html2text
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: rolepoint/html2text
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 118 files changed
  • 1 contributor

Commits on Feb 7, 2017

  1. Switch tests to parametrized py.test

    The previous test suite used a weird "dynamic patching" of a UnitTest
    class, where in fact all it needed was a sort of parametrization.
    
    PLEASE NOTE: Some tests have been moved into an /extra folder, they're
    testing some special cli flag that we're not really concerned with. The
    aim is to include them at some point, but the priority is with the base
    html->md tests.
    Gabriele Alese committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    9159527 View commit details
    Browse the repository at this point in the history
  2. Don't escape html entities

    I don't see the point of keeping HTML entities as-is during the
    conversion (i.e. not converting & into &). The reason for doing it
    that way originally is not convincing:
    #109
    Gabriele Alese committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    fa4e86f View commit details
    Browse the repository at this point in the history
  3. Fix handling of empty tables

    Empty tables resulted in a spurious `---` to underline a non-existing
    table header. Check if there is text before outputting the header marker.
    Gabriele Alese committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    da42155 View commit details
    Browse the repository at this point in the history
  4. Fix handling of emphasis

    In HTML we have plenty of examples where an emphasis tag contains one or
    more <br/> tags. The markdown specification isn't concerned with mapping
    html to markdown, so we have to play the assume game. For our purposes,
    and to my "common" sense, there's never a case when we want the closing
    `**` to be on a different line.
    Gabriele Alese committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    bf395ad View commit details
    Browse the repository at this point in the history
  5. Update dev-requirements.txt to include the full toolchain

    Gabriele Alese committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    91cc18a View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2017

  1. Don't unescape &lt; and &gt;

    Because converting those html entities leaves a door open to XSS.
    Gabriele Alese committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    7916e8b View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1 from rolepoint/fix/escape

    Fix the handling of tables, entities and emphasis
    Gabriele Alese authored Mar 28, 2017
    Configuration menu
    Copy the full SHA
    3089887 View commit details
    Browse the repository at this point in the history
  3. Update version number

    Gabriele Alese committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    ddb7c55 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2017

  1. Make html2text UNICODE_SNOB by default

    (And fix tests accordingly)
    Gabriele Alese committed Apr 11, 2017
    Configuration menu
    Copy the full SHA
    146060c View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2 from rolepoint/fix/umlauts

    Make html2text UNICODE_SNOB by default
    Gabriele Alese authored Apr 11, 2017
    Configuration menu
    Copy the full SHA
    d21ac17 View commit details
    Browse the repository at this point in the history
Loading