-
Notifications
You must be signed in to change notification settings - Fork 293
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: Alir3z4/html2text
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: rolepoint/html2text
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 10 commits
- 118 files changed
- 1 contributor
Commits on Feb 7, 2017
-
Switch tests to parametrized py.test
The previous test suite used a weird "dynamic patching" of a UnitTest class, where in fact all it needed was a sort of parametrization. PLEASE NOTE: Some tests have been moved into an /extra folder, they're testing some special cli flag that we're not really concerned with. The aim is to include them at some point, but the priority is with the base html->md tests.
Gabriele Alese committedFeb 7, 2017 Configuration menu - View commit details
-
Copy full SHA for 9159527 - Browse repository at this point
Copy the full SHA 9159527View commit details -
I don't see the point of keeping HTML entities as-is during the conversion (i.e. not converting & into &). The reason for doing it that way originally is not convincing: #109
Gabriele Alese committedFeb 7, 2017 Configuration menu - View commit details
-
Copy full SHA for fa4e86f - Browse repository at this point
Copy the full SHA fa4e86fView commit details -
Empty tables resulted in a spurious `---` to underline a non-existing table header. Check if there is text before outputting the header marker.
Gabriele Alese committedFeb 7, 2017 Configuration menu - View commit details
-
Copy full SHA for da42155 - Browse repository at this point
Copy the full SHA da42155View commit details -
In HTML we have plenty of examples where an emphasis tag contains one or more <br/> tags. The markdown specification isn't concerned with mapping html to markdown, so we have to play the assume game. For our purposes, and to my "common" sense, there's never a case when we want the closing `**` to be on a different line.
Gabriele Alese committedFeb 7, 2017 Configuration menu - View commit details
-
Copy full SHA for bf395ad - Browse repository at this point
Copy the full SHA bf395adView commit details -
Update dev-requirements.txt to include the full toolchain
Gabriele Alese committedFeb 7, 2017 Configuration menu - View commit details
-
Copy full SHA for 91cc18a - Browse repository at this point
Copy the full SHA 91cc18aView commit details
Commits on Mar 28, 2017
-
Because converting those html entities leaves a door open to XSS.
Gabriele Alese committedMar 28, 2017 Configuration menu - View commit details
-
Copy full SHA for 7916e8b - Browse repository at this point
Copy the full SHA 7916e8bView commit details -
Merge pull request #1 from rolepoint/fix/escape
Fix the handling of tables, entities and emphasis
Gabriele Alese authoredMar 28, 2017 Configuration menu - View commit details
-
Copy full SHA for 3089887 - Browse repository at this point
Copy the full SHA 3089887View commit details -
Gabriele Alese committed
Mar 28, 2017 Configuration menu - View commit details
-
Copy full SHA for ddb7c55 - Browse repository at this point
Copy the full SHA ddb7c55View commit details
Commits on Apr 11, 2017
-
Make html2text UNICODE_SNOB by default
(And fix tests accordingly)
Gabriele Alese committedApr 11, 2017 Configuration menu - View commit details
-
Copy full SHA for 146060c - Browse repository at this point
Copy the full SHA 146060cView commit details -
Merge pull request #2 from rolepoint/fix/umlauts
Make html2text UNICODE_SNOB by default
Gabriele Alese authoredApr 11, 2017 Configuration menu - View commit details
-
Copy full SHA for d21ac17 - Browse repository at this point
Copy the full SHA d21ac17View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master