Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: launchbadge/sqlx
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: rmagatti/sqlx
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 14 commits
  • 9 files changed
  • 2 contributors

Commits on Oct 23, 2024

  1. Configuration menu
    Copy the full SHA
    00d63e1 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Configuration menu
    Copy the full SHA
    cb190bd View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2025

  1. Configuration menu
    Copy the full SHA
    9c07a03 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2025

  1. Configuration menu
    Copy the full SHA
    c9148a0 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2025

  1. Merge upstream main while preserving custom environment variable supp…

    …ort for migrations schema and table
    rmagatti committed Jul 11, 2025
    Configuration menu
    Copy the full SHA
    6be8f5d View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2025

  1. Fox delimiter and format

    rmagatti committed Jul 15, 2025
    Configuration menu
    Copy the full SHA
    190d9d4 View commit details
    Browse the repository at this point in the history
  2. feat(migrate): move custom schema/table config to core level

    Move PostgreSQL-specific custom schema and table name functionality from
    the Postgres implementation to the core configuration level, making it
    available for all databases while respecting their schema support.
    
    - Add database-specific configuration via `[migrate.drivers.postgres]`
    - Support environment variables SQLX_MIGRATIONS_TABLE and SQLX_MIGRATIONS_SCHEMA
    - Add qualified_table_name() method that returns schema-qualified names for PostgreSQL
    - Update CLI to use backend_name() to detect database type
    - Remove hardcoded environment variables from Postgres implementation
    - Maintain backward compatibility with existing environment variables
    
    This provides a cleaner, more maintainable approach that works across
    all databases while properly handling PostgreSQL's schema support.
    rmagatti committed Jul 15, 2025
    Configuration menu
    Copy the full SHA
    040db2e View commit details
    Browse the repository at this point in the history
  3. fix(migrate): ensure environment variables work with config file loading

    When loading config from a TOML file, environment variables were not being
    read because the Default trait is only called for missing fields during
    deserialization. This fix ensures that SQLX_MIGRATIONS_TABLE and
    SQLX_MIGRATIONS_SCHEMA are checked at runtime in the qualified_table_name()
    and postgres_schema() methods.
    
    This ensures environment variables work correctly whether using
    Config::default() directly or loading from a sqlx.toml file.
    rmagatti committed Jul 15, 2025
    Configuration menu
    Copy the full SHA
    a2f3791 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2025

  1. Fix table name usage?

    rmagatti committed Jul 16, 2025
    Configuration menu
    Copy the full SHA
    4dac3ee View commit details
    Browse the repository at this point in the history
  2. fix(migrate): handle String return type from table_name() in macro

    The migrate\! macro was expecting table_name() to return &str but it now
    returns String (to support schema-qualified names). This fix converts
    the String to &str before passing it to Cow::Borrowed.
    
    This allows the migrate\! macro to properly embed schema-qualified table
    names (like "my_schema._sqlx_migrations") at compile time when using
    sqlx.toml configuration.
    rmagatti committed Jul 16, 2025
    Configuration menu
    Copy the full SHA
    5093fd6 View commit details
    Browse the repository at this point in the history
  3. refactor(migrate): clean up PostgreSQL schema configuration implement…

    …ation
    
    - Remove redundant qualified_table_name() method as table_name() already handles schema qualification
    - Fix test compilation error by removing undefined MIGRATION_TABLE reference
    - Extract duplicated schema creation logic into ensure_migration_schemas() helper
    - Remove commented dead code and unrelated debug logging
    - Update tests to reflect the simplified API
    
    The table_name() method now returns the appropriate format for each database:
    - PostgreSQL: schema.table (e.g., "public._sqlx_migrations")
    - Other databases: table only (e.g., "_sqlx_migrations")
    
    🤖 Generated with [Claude Code](https://claude.ai/code)
    
    Co-Authored-By: Claude <noreply@anthropic.com>
    rmagatti and claude committed Jul 16, 2025
    Configuration menu
    Copy the full SHA
    3d4d14f View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2025

  1. Merge upstream changes: resolve connect() signature conflicts

    - Accept upstream connect(config, opts) signature for crate::connect()
    - Preserve custom migration table_name functionality
    - Fix PostgreSQL schema handling with AnyConnection backend_name()
    - Update test table_name() call to use reference
    - All tests passing and functionality verified
    rmagatti committed Sep 4, 2025
    Configuration menu
    Copy the full SHA
    2c60615 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2025

  1. Configuration menu
    Copy the full SHA
    a585f93 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2025

  1. Configuration menu
    Copy the full SHA
    f7163c5 View commit details
    Browse the repository at this point in the history
Loading