Skip to content

Breaking change between 0.7.7 and 0.7.8 #267

@Zippy1999

Description

@Zippy1999

In 0.7.8 some additional code is in play

        if AIOHTTP_VERSION >= Version('3.8.0'):
            # Join url with ClientSession._base_url
            url = orig_self._build_url(url)
            url_origin = str(url)
            # Combine ClientSession headers with passed headers
            if orig_self.headers:
                kwargs["headers"] = orig_self._prepare_headers(kwargs.get("headers"))
        else:
            url_origin = url

The main change is

 url = orig_self._build_url(url)

When the final url is presented, it includes the host AND path. This means our previous tests setup where we were just setting the path are starting to fail

Was this desired behaviour or is this a bug? - I'm checking in here as if it is NOT a bug I will need to set about changing my test assertions.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions