Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nmwsharp/polyscope
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: payoto/polyscope
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Aug 8, 2021

  1. Remove reliance on GLFW for mock when disabled 

    The documentation states that the OpenGL backend can be disabled by
building with `cmake -DPOLYSCOPE_BACKEND_OPENGL3_GLFW=OFF ..`
However running make on the result leads to an error:

In file included from polyscope/src/../include/polyscope/render/opengl/shaders/common.h:8,
                 from
                 polyscope/src/render/mock_opengl/mock_gl_engine.cpp:13:
polyscope/src/../include/polyscope/render/opengl/gl_engine.h:12:10: fatal error: glad/glad.h: No such file or directory
   12 | #include "glad/glad.h"
      |          ^~~~~~~~~~~~~

This is due to the mocked backend depending on glad. This commit uses
compiler flags to disable that include.
    @payoto
    payoto committed Aug 8, 2021
    Configuration menu
    Copy the full SHA
    810a5cc View commit details
    Browse the repository at this point in the history
Loading