From b332a64141daaf6d3f49aa16a87f16c1e198e7b3 Mon Sep 17 00:00:00 2001 From: g-abilio Date: Thu, 18 Dec 2025 15:09:57 -0300 Subject: [PATCH] solve existing warnings in msvc build process --- CMakeLists.txt | 3 +++ src/AbstractGraphModel.cpp | 8 ++++++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index cf036012f..51db1f685 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -165,6 +165,9 @@ target_compile_definitions(QtNodes QT_NO_KEYWORDS ) +if(MSVC) + string(REGEX REPLACE "/W[0-4]" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}") +endif() target_compile_options(QtNodes PRIVATE diff --git a/src/AbstractGraphModel.cpp b/src/AbstractGraphModel.cpp index 10709b7e8..3ea47435d 100644 --- a/src/AbstractGraphModel.cpp +++ b/src/AbstractGraphModel.cpp @@ -40,7 +40,9 @@ void AbstractGraphModel::portsAboutToBeDeleted(NodeId const nodeId, // Erases the information about the port on one side; auto c = makeIncompleteConnectionId(connectionId, portType); - c = makeCompleteConnectionId(c, nodeId, portIndex - nRemovedPorts); + c = makeCompleteConnectionId(c, + nodeId, + portIndex - static_cast(nRemovedPorts)); _shiftedByDynamicPortsConnections.push_back(c); @@ -84,7 +86,9 @@ void AbstractGraphModel::portsAboutToBeInserted(NodeId const nodeId, // Erases the information about the port on one side; auto c = makeIncompleteConnectionId(connectionId, portType); - c = makeCompleteConnectionId(c, nodeId, portIndex + nNewPorts); + c = makeCompleteConnectionId(c, + nodeId, + portIndex + static_cast(nNewPorts)); _shiftedByDynamicPortsConnections.push_back(c);