Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mozsearch/ipdl_parser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: mozsearch/ipdl_parser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: divergence
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 5 files changed
  • 2 contributors

Commits on Mar 19, 2022

  1. Merge pull request #9 from amccreight/master

    Fix parse() to actually match the API SearchFox expects.
    amccreight authored Mar 19, 2022
    Configuration menu
    Copy the full SHA
    ef3d26f View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. Configuration menu
    Copy the full SHA
    7f3a198 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2022

  1. Print out errors when ignoring them.

    This is not ideal as a default behavior, but we are already printing
    out the filename as we parse it, so it is consistent!  This makes it
    easier for us to figure out why an IPDL file is not indexed in
    searchfox by checking the index-log.  This could be better addressed
    by introducing a concept of an error record that the parser could emit
    into an analysis file so that we could display what's broken when
    looking at the file in searchfox, potentially on an opt-in basis.
    asutherland committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    ab51d36 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #10 from asutherland/print-errors

    Print out errors when ignoring them.
    asutherland authored Jun 11, 2022
    Configuration menu
    Copy the full SHA
    ab07da1 View commit details
    Browse the repository at this point in the history
  3. Add naive support for [ManualAlloc, ChildImpl=virtual] annotations.

    The parser does not seem to like annotations inclusive of both the
    `[ManualAlloc]` type added in
    https://bugzilla.mozilla.org/show_bug.cgi?id=1736371 and the variations
    that also include list of annotations in the patch that look like
    `[ManualDealloc, ChildImpl=virtual, ParentImpl=virtual]`.
    
    My efforts here are to try and get this to parse and technically
    produce something usable, but I wouldn't be surprised if someone wanted
    to properly consume the annotations that they would want something that
    looks more strongly typed.  But this is an AST so maybe this is fine?
    asutherland committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    2dc46ff View commit details
    Browse the repository at this point in the history
  4. Merge pull request #11 from asutherland/manual-dealloc

    Add naive support for `[ManualAlloc, ChildImpl=virtual]` annotations.
    asutherland authored Jun 11, 2022
    Configuration menu
    Copy the full SHA
    d85c23f View commit details
    Browse the repository at this point in the history
Loading