-
Notifications
You must be signed in to change notification settings - Fork 128
Open
Labels
Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.Required for internal Azure reporting. Do not delete. Do not change color.bugIndicates an unexpected problem or an unintended behavior.Indicates an unexpected problem or an unintended behavior.customer-replied-toRequired for internal reporting. Do not delete.Required for internal reporting. Do not delete.customer-reportedRequired for internal Azure reporting. Do not delete.Required for internal Azure reporting. Do not delete.
Description
When disconnecting a connection that has pending requests, the infra botframework-streaming package rejects all the requests with "Disconnect was called" error.
It looks like the botframework-directlinejs package writes this error to the console instead/in addition to emitting an error event to the application.
This bypasses our logging system, and should not be done by libraries.
I suspect the console log comes from here or from here.
There are other calls to console.warn and console.error in the library. They should be replaced where possible with proper error propagation.
Metadata
Metadata
Assignees
Labels
Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.Required for internal Azure reporting. Do not delete. Do not change color.bugIndicates an unexpected problem or an unintended behavior.Indicates an unexpected problem or an unintended behavior.customer-replied-toRequired for internal reporting. Do not delete.Required for internal reporting. Do not delete.customer-reportedRequired for internal Azure reporting. Do not delete.Required for internal Azure reporting. Do not delete.