Skip to content

DirectlineStreaming: Errors on disconnect are written to console #414

@orgads

Description

@orgads

When disconnecting a connection that has pending requests, the infra botframework-streaming package rejects all the requests with "Disconnect was called" error.

It looks like the botframework-directlinejs package writes this error to the console instead/in addition to emitting an error event to the application.

This bypasses our logging system, and should not be done by libraries.

I suspect the console log comes from here or from here.

There are other calls to console.warn and console.error in the library. They should be replaced where possible with proper error propagation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.bugIndicates an unexpected problem or an unintended behavior.customer-replied-toRequired for internal reporting. Do not delete.customer-reportedRequired for internal Azure reporting. Do not delete.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions