Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: splitrb/split
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: mcls/split
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Jun 25, 2018

  1. CookieAdapter: Fix cookies when @context is an ActionController 

    Using ab_test from a controller was failing because "cookies" is a
private method of the controller instance which is assigned to @context.

It looks like this was broken in the commit that fixed the multiple
"Set-Cookie" headers bug:
3523e1c

Using `.send(:cookies)` again when using Rails was the easiest way I
found to fix this.

Note: I was able to add an integration test for the case when it's
called from the controller, but I failed to a regression test that uses
and ActionView context object.
    @mcls
    mcls committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    5642c46 View commit details
    Browse the repository at this point in the history

  2. Don't use to_h on CookieJar, it doesn't work on older rubies

    @mcls
    mcls committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    113b88e View commit details
    Browse the repository at this point in the history
Loading