Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: brasse/SimpleNotes
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: mattr-/SimpleNotes
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 8 files changed
  • 1 contributor

Commits on Nov 16, 2011

  1. Rearrange the tests 

    Put the tests in their own folder in the same package.

Rename the API test to SimpleNoteAPIImplTest since it's really a test of
te API implementation rather than the interface.
    @mattrdash
    mattrdash committed Nov 16, 2011
    Configuration menu
    Copy the full SHA
    1339d7c View commit details
    Browse the repository at this point in the history

  2. Require Android 2.2 or later. 

    There's not enough of the older devices out there to continue supporting
them.
    @mattrdash
    mattrdash committed Nov 16, 2011
    Configuration menu
    Copy the full SHA
    d083f7d View commit details
    Browse the repository at this point in the history

  3. update the classpaths

    @mattrdash
    mattrdash committed Nov 16, 2011
    Configuration menu
    Copy the full SHA
    d97cdff View commit details
    Browse the repository at this point in the history

  4. Move noteFromJSON and noteToJSON to the Note class 

    The Note class is where they belong since they operate on Note objects.

Note.fromJSON is static and will return a new Note object from JSON.
Note.toJSON is not static and requires an instantiated Note in order to
operate.

Also included as a bonus: a unit test. :)
    @mattrdash
    mattrdash committed Nov 16, 2011
    Configuration menu
    Copy the full SHA
    dce407f View commit details
    Browse the repository at this point in the history
Loading