Skip to content
This repository was archived by the owner on Apr 19, 2024. It is now read-only.
This repository was archived by the owner on Apr 19, 2024. It is now read-only.

More unit tests needed + Upload code coverage to CodeCov #215

@miparnisari

Description

@miparnisari

make test in master currently reports 49.0% code coverage overall. There are multiple critical code paths not covered with tests. For example:

  • algorithms.go only has 81% and is arguably the most important piece of code.
  • global.go only has 84.2% and has no unit tests (😱)

It would be nice if, going forward, we block PRs that do not include tests. I suggest enabling Codecov through https://github.com/marketplace/codecov and uploading code coverage in every PR and for every push to main.

For example: https://github.com/openfga/openfga/blob/164963facc61241e1378d8fefb6632c700407163/.github/workflows/pull_request.yaml#L49-L57

The end goal would be the overall code coverage to a healthier number.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions