Auto-title is broken

[laurent22]

Version 3.5.2

• Create a new note
• Type something in the body

=> The title is automatically set to the same string as the body, but is then immediately cleared.

I think it may be due to this change:

42a156c#diff-281e5fcbea99432c2cc060ba64559a6b55f49cf178b8cfbf3237a5fae810301dR34

But since it's part of a much bigger commit it's unclear how it broke or how to fix it. If I revert to just before this commit, it works again. I've also checked several more recent commits but this seems the most likely culprit.

[personalizedrefrigerator]

Thank you for reporting this!

I'm attaching a few notes:

• 42a156c is in Joplin >= 3.4.2. As such, (if caused by this commit), this probably isn't a regression in v3.5.
• If I recall correctly, the change to note-screen-shared was related to the upgrade to React 19.
  • Edit: The change was made in this commit, to fix test failures that occurred after the upgrade. It was given the comment (in the notes section of the PR),

    screens/Note.tsx is updated to pass the state at the time a save was triggered to shared.saveNoteButton_press. This prevents a race condition that occurs during testing with the updated version of @testing-library/react-native and/or React:

    • A change is made from the editor and a save is scheduled.
    • The scheduled save occurs with the component's current .state.
    • The setState from (1) is applied, updating the component's .state.
    • The test waits for the note to have been saved with the change from (1). This never happens because the change scheduled in (2) accessed the note body from an outdated .state.

• This pull request fixed a potentially-similar regression related to note state.
• This might be Android-specific—auto-title seems to work in the iOS app (Joplin 13.5.1) and the web app.

[personalizedrefrigerator]

This might be Android-specific—auto-title seems to work in the iOS app and the web app.

Re-tagging as "android". If this can be reproduced on other platforms, I can change the tag back to "mobile".

[mrjo118]

@laurent22 Is the bug happening in the specified version of 3.5.2 a mistake? The latest pre-release on mobile is 3.5.1 and I havn't been able to reproduce the issue on that version on Android. I guess it is intermittent?

Also is the issue you are describing the same as what you mentioned in this comment for the iOS app? #13457 (comment). Or were you able to reproduce even without pasting text into the body? I did manage to reproduce the issue at some point in 3.4.7 on Android as well, by pasting text into the body, see #13515 (comment)

[laurent22]

Hmm, on Android I'm on 3.5.2 and it happens every time. And yesterday I was doing my tests with the iOS emulator and it also happens every time.

Also is the issue you are describing the same as what you mentioned in this comment for the iOS app? #13457 (comment)

Yes this issue