This will open a new screen. Save your current changes? on tabs with no changes

[horvatkm]

Operating system

Windows

Joplin version

3.5.7

Desktop version info

Joplin 3.5.7 (prod, win32)

Sync Version: 3
Profile Version: 49
Keychain Supported: Yes
Alternative instance ID: -

Revision: 7a31f1f

Backup: 1.4.3
Freehand Drawing: 3.1.0

Current behaviour

I've encountered minor issue regarding Options panel. Question dialog "This will open a new screen. Save your current changes?" keeps popping out on tabs, on which no changes were made.

Steps to reproduce.

1. Open Options panel, activate Application tab, uncheck Automatically check for updates
2. Keep clicking through tabs
3. When leaving Synchronization, Note History and Web Clipper and Key Shortcuts tab, a questions pops out: "This will open a new screen. Save your current changes?", even thought I've changed nothing on these tabs.

Expected behaviour

Question dialog "This will open a new screen. Save your current changes?" should pop out only when leaving tabs with changes.

Logs

No response

[mrjo118]

This behaviour is by design. It's only when switching to certain settings screens (which are considered a new screen) or when exiting settings, that an error will be raised if the settings state is 'dirty'

[horvatkm]

Current behavior is a bit confusing. The question dialog should appear only when leaving tab with changed settings.

Therefore, when the only changed setting is on Application tab, question dialog should appear when leaving Application tab. But it does not show.

It also appears when leaving tabs with no settings changed on these tabs, for example Web Clipper and Key Shortcuts. Actually, there are no configurable settings on these tabs at all.

[mrjo118]

Arguably if you give an unsaved changes prompt after leaving any settings page, that would give a worse user experience, as a user might want to change things across a variety of screens before saving and its annoying to need to click save multiple times. The ideal would be to only prompt when leaving the settings entirely, but I think there are likely some reasons that changes should be saved before switching to certain screens within the settings. My guess is because some settings auto save when toggled, so on screens with such options, the user is prompted before switching, so that it wont silently save changes without the user being aware, as the user may have just been playing around with setting toggles, without an intention to commit the changes

[horvatkm]

The reason why question dialog pops out seems to be that Web Clipper/Key Shortcuts tabs have Back button only. Having same buttons (Back/OK/Apply) on all tabs would IMHO give better user experience, since there would be no need for question dialog.