chore: update golangci-lint (#34)

Author: ldez

.github/workflows/ci.yaml

@@ -9,7 +9,7 @@ on:
 
 env:
   GO_VERSION: oldstable
-  GOLANGCI_LINT_VERSION: v1.64.8
+  GOLANGCI_LINT_VERSION: v2.1
 
 jobs:
   go_install:
@@ -30,10 +30,9 @@ jobs:
         with:
           go-version: ${{ env.GO_VERSION }}
       - uses: actions/checkout@v3
-      - uses: golangci/golangci-lint-action@v6.5.2
+      - uses: golangci/golangci-lint-action@v8
         with:
           version: ${{ env.GOLANGCI_LINT_VERSION }}
-          args: --timeout=5m
 
   test:
     runs-on: ubuntu-latest

.golangci.yml

@@ -1,7 +1,5 @@
-## A good ref for this: https://gist.github.com/maratori/47a4d00457a92aa426dbd48a18776322
-
+version: "2"
 run:
-  timeout: 5m
   tests: true
 linters:
   enable:
@@ -14,16 +12,11 @@ linters:
     - dogsled
     - dupword # checks for duplicate words in the source code
     - durationcheck # checks for two durations multiplied together
-    - errcheck
     - errname
     - errorlint
-    - gci
     - gochecknoinits # checks that no init functions are present in Go code
     - gocritic
-    - gosimple
-    - govet
     - importas # enforces consistent import aliases
-    - ineffassign
     - loggercheck
     - makezero # finds slice declarations with non-zero initial length
     - mirror
@@ -39,55 +32,61 @@ linters:
     - reassign # checks that package variables are not reassigned
     - revive # fast, configurable, extensible, flexible, and beautiful linter for Go, drop-in replacement of golint
     - staticcheck
-    - stylecheck
     - thelper # detects golang test helpers without t.Helper() call and checks the consistency of test helpers
     - unconvert # removes unnecessary type conversions
     - unparam # reports unused function parameters
     - unused
     - usestdlibvars # detects the possibility to use variables/constants from the Go standard library
     - wastedassign # finds wasted assignment statements
     - whitespace # detects leading and trailing whitespace
-linters-settings:
-  gci:
-    skip-generated: true
-    custom-order: true
-    sections:
-      - standard # Standard section: captures all standard packages.
-      - default # Default section: contains all imports that could not be matched to another section type.
-      - prefix(github.com/jjti)
-  gocritic:
-    settings:
-      captLocal:
-        # Whether to restrict checker to params only.
-        # Default: true
-        paramsOnly: false
-      underef:
-        # Whether to skip (*x).method() calls where x is a pointer receiver.
-        # Default: true
-        skipRecvDeref: false
-  govet:
-    enable-all: true
-    disable:
-      - fieldalignment # too strict
-      - shadow # bunch of false positive, doesn't realize when we return from a func
-  misspell:
-    locale: US
-  nakedret:
-    max-func-lines: 0
-  nestif:
-    # Minimal complexity of if statements to report.
-    # Default: 5
-    min-complexity: 5
-  nolintlint:
-    # Enable to require an explanation of nonzero length after each nolint directive.
-    # Default: false
-    require-explanation: true
-  stylecheck:
-    checks: ["all"]
-issues:
-  include:
-    - EXC0001 # Error return value of x is not checked
-    - EXC0013 # package comment should be of the form "(.+)...
-    - EXC0014 # comment on exported (.+) should be of the form "(.+)..."
-  exclude:
-    - ifElseChain
+
+  settings:
+    gocritic:
+      settings:
+        captLocal:
+          # Whether to restrict checker to params only.
+          # Default: true
+          paramsOnly: false
+        underef:
+          # Whether to skip (*x).method() calls where x is a pointer receiver.
+          # Default: true
+          skipRecvDeref: false
+    govet:
+      disable:
+        - fieldalignment # too strict
+        - shadow # bunch of false positive, doesn't realize when we return from a func
+      enable-all: true
+    misspell:
+      locale: US
+    nakedret:
+      max-func-lines: 0
+    nestif:
+      # Minimal complexity of if statements to report.
+      # Default: 5
+      min-complexity: 5
+    nolintlint:
+      # Enable to require an explanation of nonzero length after each nolint directive.
+      # Default: false
+      require-explanation: true
+    staticcheck:
+      checks:
+        - all
+
+  exclusions:
+    presets:
+      - common-false-positives
+      - legacy
+    rules:
+      - path: (.+)\.go$
+        text: ifElseChain
+
+formatters:
+  enable:
+    - gci
+  settings:
+    gci:
+      sections:
+        - standard # Standard section: captures all standard packages.
+        - default # Default section: contains all imports that could not be matched to another section type.
+        - prefix(github.com/jjti)
+      custom-order: true

cmd/spancheck/main.go

@@ -1,3 +1,4 @@
+// Package main is the command line for go-spancheck.
 package main
 
 import (