Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: frontend-collective/react-sortable-tree
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: jcalebj/react-sortable-tree
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Mar 8, 2018

  1. fix: recalculate rowHeight() when isVirualized 

    When rendering rows with isVirualized, if rowHeight is a func, the
virtualized list was not recalculating the rowHeight.
Per the `react-virtualized` docs
[here](https://github.com/bvaughn/react-virtualized/blob/master/docs/Lis
t.md#recomputerowheights-index-number), `List.recomputeRowHeights()`
needs to be called.

This only fixes the dynamic rowHeight issue _after_ dragging a node is
finished.  An additional `List.recomputeRowHeights()` will need to be
called to fix the ‘preview’ while dragging a row (see issue below for
more details).

This partially fixes [Issue
264](#264).
    @jcalebj
    jcalebj committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    6c433d5 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2018

  1. semi-fix: recalculate rowHeight() when dragging

    @jcalebj
    jcalebj committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    c6b8d32 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from jcalebj/cj/react-sortable-tree-teamgantt 

    Cj/react sortable tree teamgantt
    @jcalebj
    jcalebj authored Mar 12, 2018
    Configuration menu
    Copy the full SHA
    0c4b5a6 View commit details
    Browse the repository at this point in the history
Loading