Add verbosity to pg_basebackup for sync

michaelpq · michaelpq · commit fa7d5b704a37 · 2018-07-29T07:53:11.000+09:00
This is useful to know when the data copy has been finished. The current situation can be confusing for users as the last message is "waiting for background process to finish streaming", so it looks like this is taking time but the final sync is instead. Author: Jeff Janes Discussion: https://postgr.es/m/CAMkU=1ypeoMJ=tFBG8vP13sxEtXd4Pm_x1SqsJdW_RvzpcvN=A@mail.gmail.com
diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c
@@ -2112,6 +2112,9 @@ BaseBackup(void)
 	 */
 	if (do_sync)
 	{
+		if (verbose)
+			fprintf(stderr,
+					_("%s: syncing data to disk ...\n"), progname);
 		if (format == 't')
 		{
 			if (strcmp(basedir, "-") != 0)

Original file line number	Diff line number	Diff line change
`@@ -2112,6 +2112,9 @@ BaseBackup(void)`
`2112`	`2112`	`*/`
`2113`	`2113`	`if (do_sync)`
`2114`	`2114`	`{`
	`2115`	`+ if (verbose)`
	`2116`	`+ fprintf(stderr,`
	`2117`	`+ _("%s: syncing data to disk ...\n"), progname);`
`2115`	`2118`	`if (format == 't')`
`2116`	`2119`	`{`
`2117`	`2120`	`if (strcmp(basedir, "-") != 0)`