Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: OpenMined/PySyft
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ivuckovic/PySyft
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 5 files changed
  • 1 contributor

Commits on Oct 30, 2017

  1. Convert dense matrix to sparse (#274) 

    * Implement function that converts dense matrix to sparse

* Add sparse function to tensor.py
    @ivuckovic
    ivuckovic committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    98eecbe View commit details
    Browse the repository at this point in the history

  2. Convert dense matrix to sparse (#274) 

    * Implement function that converts dense matrix to sparse
    @ivuckovic
    ivuckovic committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    d4be877 View commit details
    Browse the repository at this point in the history

  3. Convert dense to sparse matrix - Issue 274 

    * Add skeleton definition for conversion of dense to sparse matrix
    @ivuckovic
    ivuckovic committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    666f144 View commit details
    Browse the repository at this point in the history

  4. Convert dense matrix to sparse (#274) 

    * fix test cases, but still getting errors when trying to assert.equal two numpy.ndarrays
    @ivuckovic
    ivuckovic committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    00bff2e View commit details
    Browse the repository at this point in the history

  5. Convert dense matrix to sparse (#274) 

    * fix tests by converting output of sparse function to string
  This was necessary because assert.equal returning errors when trying to compare two numpy arrays
    @ivuckovic
    ivuckovic committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    7b6bf6d View commit details
    Browse the repository at this point in the history

  6. Convert dense matrix to sparse (#274) 

    * rebase branch onto newest commit on master
* fix comments, naming conventions and placement of definitions in code according to review comments
    @ivuckovic
    ivuckovic committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    2a3e2f7 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2017

  1. Dense to sparse matrix conversion (#274) 

    * Fix styling errors in tenosr.py, test_tensor.py and test_math.py according to review comments
    @ivuckovic
    ivuckovic committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    e1eded8 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2017

  1. Convert dense matrix to sparse (#274) 

    * Fix styling errors - comment from reviewer
    @ivuckovic
    ivuckovic committed Nov 2, 2017
    Configuration menu
    Copy the full SHA
    e59466c View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2017

  1. Convert dense matrix to sparse (#274) 

    * fix styling errors that were causing Travis fails
    @ivuckovic
    ivuckovic committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    17acc82 View commit details
    Browse the repository at this point in the history
Loading