Skip to content

Commit b2cde31

Browse files
author
pifupro_iOS_admin
committed
⓵convert some constants (#define) to extern or static
const⓶Optimization of code format
1 parent ccbcc0a commit b2cde31

33 files changed

+118
-59
lines changed

CollectionViewClassifyMenu.xcodeproj/xcuserdata/chenyilong.xcuserdatad/xcdebugger/Breakpoints_v2.xcbkptlist

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,11 @@
5252
ignoreCount = "0"
5353
continueAfterRunningActions = "No"
5454
filePath = "CollectionViewClassifyMenu/Class/ClassifyMenu(两级可折叠菜单)/Controller/CYLClassifyMenuViewController.m"
55-
timestampString = "452073075.243941"
55+
timestampString = "452495015.486241"
5656
startingColumnNumber = "9223372036854775807"
5757
endingColumnNumber = "9223372036854775807"
58-
startingLineNumber = "256"
59-
endingLineNumber = "256"
58+
startingLineNumber = "257"
59+
endingLineNumber = "257"
6060
landmarkName = "-judgeMoreBtnShowWhenShowTwoLine"
6161
landmarkType = "5">
6262
</BreakpointContent>
@@ -68,11 +68,11 @@
6868
ignoreCount = "0"
6969
continueAfterRunningActions = "No"
7070
filePath = "CollectionViewClassifyMenu/Class/ClassifyMenu(&#x4e24;&#x7ea7;&#x53ef;&#x6298;&#x53e0;&#x83dc;&#x5355;)/Controller/CYLClassifyMenuViewController.m"
71-
timestampString = "452073075.243941"
71+
timestampString = "452495015.486241"
7272
startingColumnNumber = "9223372036854775807"
7373
endingColumnNumber = "9223372036854775807"
74-
startingLineNumber = "254"
75-
endingLineNumber = "254"
74+
startingLineNumber = "255"
75+
endingLineNumber = "255"
7676
landmarkName = "-judgeMoreBtnShowWhenShowTwoLine"
7777
landmarkType = "5">
7878
</BreakpointContent>
@@ -84,11 +84,11 @@
8484
ignoreCount = "0"
8585
continueAfterRunningActions = "No"
8686
filePath = "CollectionViewClassifyMenu/Class/ClassifyMenu(&#x4e24;&#x7ea7;&#x53ef;&#x6298;&#x53e0;&#x83dc;&#x5355;)/Controller/CYLClassifyMenuViewController.m"
87-
timestampString = "452073075.243941"
87+
timestampString = "452495015.486241"
8888
startingColumnNumber = "9223372036854775807"
8989
endingColumnNumber = "9223372036854775807"
90-
startingLineNumber = "434"
91-
endingLineNumber = "434"
90+
startingLineNumber = "435"
91+
endingLineNumber = "435"
9292
landmarkName = "-showLineSwitchClicked:"
9393
landmarkType = "5">
9494
<Locations>
@@ -147,11 +147,11 @@
147147
ignoreCount = "0"
148148
continueAfterRunningActions = "No"
149149
filePath = "CollectionViewClassifyMenu/Class/ClassifyMenu(&#x4e24;&#x7ea7;&#x53ef;&#x6298;&#x53e0;&#x83dc;&#x5355;)/Controller/CYLClassifyMenuViewController.m"
150-
timestampString = "452073075.243941"
150+
timestampString = "452495015.486241"
151151
startingColumnNumber = "9223372036854775807"
152152
endingColumnNumber = "9223372036854775807"
153-
startingLineNumber = "252"
154-
endingLineNumber = "252"
153+
startingLineNumber = "253"
154+
endingLineNumber = "253"
155155
landmarkName = "-judgeMoreBtnShowWhenShowTwoLine"
156156
landmarkType = "5">
157157
<Locations>

CollectionViewClassifyMenu/Class/ClassifyMenu(两级可折叠菜单)/Controller/CYLClassifyMenuViewController.m

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,18 @@
66
// Copyright (c) http://weibo.com/luohanchenyilong/ . All rights reserved.
77
// Single Choice Filter
88

9-
#define kControllerHeaderViewHeight 90
10-
#define kControllerHeaderToCollectionViewMargin 0
11-
#define kCollectionViewCellsHorizonMargin 12
12-
#define kCollectionViewCellHeight 30
13-
#define kCollectionViewItemButtonImageToTextMargin 5
9+
static float const kControllerHeaderViewHeight = 90.f;
10+
static float const kControllerHeaderToCollectionViewMargin = 0;
11+
static float const kCollectionViewCellsHorizonMargin = 12;
12+
static float const kCollectionViewCellHeight = 30;
13+
static float const kCollectionViewItemButtonImageToTextMargin = 5;
1414

15-
#define kCollectionViewToLeftMargin 16
16-
#define kCollectionViewToTopMargin 12
17-
#define kCollectionViewToRightMargin 16
18-
#define kCollectionViewToBottomtMargin 10
15+
static float const kCollectionViewToLeftMargin = 16;
16+
static float const kCollectionViewToTopMargin = 12;
17+
static float const kCollectionViewToRightMargin = 16;
18+
static float const kCollectionViewToBottomtMargin = 10;
1919

20-
#define kCellImageToLabelMargin 10
21-
#define kCellBtnCenterToBorderMargin 19
20+
static float const kCellBtnCenterToBorderMargin = 19;
2221

2322
#import "CYLClassifyMenuViewController.h"
2423
#import "UICollectionViewLeftAlignedLayout.h"
@@ -29,6 +28,7 @@
2928
static NSString * const kCellIdentifier = @"CellIdentifier";
3029
static NSString * const kHeaderViewCellIdentifier = @"HeaderViewCellIdentifier";
3130
typedef void(^ISLimitWidth)(BOOL yesORNo,id data);
31+
3232
@interface CYLClassifyMenuViewController ()
3333
<
3434
UICollectionViewDataSource,
@@ -45,6 +45,7 @@ @interface CYLClassifyMenuViewController ()
4545
@property (nonatomic, strong) NSMutableArray *expandSectionArray;
4646
@property (nonatomic, strong) UIScrollView *bgScrollView;
4747
@property (nonatomic, strong) UILabel *titleLabel;
48+
4849
@end
4950

5051
@implementation CYLClassifyMenuViewController

CollectionViewClassifyMenu/Class/ClassifyMenu(两级可折叠菜单)/Controller/CYLMainViewController.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,16 @@
77
// Created by https://github.com/ChenYilong on 15/4/26.
88
// Copyright (c) http://weibo.com/luohanchenyilong/ . All rights reserved.
99
//
10-
#define kMultipleFilterSettingModified @"kMultipleFilterSettingModified"
1110

1211
#import "CYLMainViewController.h"
1312
#import "CYLMultipleFilterController.h"
1413
#import "AppDelegate.h"
1514
#import "CYLFilterParamsTool.h"
1615

17-
1816
@interface CYLMainViewController ()<FilterControllerDelegate>
17+
1918
@property (nonatomic, strong) CYLMultipleFilterController *filterController;
20-
@property (nonatomic, strong) CYLFilterParamsTool *filterParamsTool;
19+
@property (nonatomic, strong) CYLFilterParamsTool *filterParamsTool;
2120

2221
@end
2322

@@ -134,4 +133,5 @@ - (void)filterControllerDidCompleted:(FilterBaseController *)controller
134133
[alert dismissWithClickedButtonIndex:0 animated:YES];
135134
});
136135
}
136+
137137
@end

CollectionViewClassifyMenu/Class/ClassifyMenu(两级可折叠菜单)/Other/Category/UIButton+CollectionCellStyle.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@
99
#import <UIKit/UIKit.h>
1010

1111
@interface UIButton (CollectionCellStyle)
12+
1213
- (void)generalStyle;
1314
- (void)homeStyle;
1415
- (void)redStyle;
16+
1517
@end

CollectionViewClassifyMenu/Class/ClassifyMenu(两级可折叠菜单)/Other/Category/UIButton+CollectionCellStyle.m

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#import "UIButton+CollectionCellStyle.h"
1010

1111
@implementation UIButton (CollectionCellStyle)
12+
1213
- (void)generalStyle {
1314
self.layer.cornerRadius = 5.0;
1415
self.backgroundColor = [UIColor whiteColor];
@@ -50,4 +51,5 @@ + (UIImage *)imageWithColor:(UIColor *)color {
5051

5152
return image;
5253
}
54+
5355
@end

CollectionViewClassifyMenu/Class/ClassifyMenu(两级可折叠菜单)/View/CYLFilterHeaderView.h

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,27 @@
66
// Copyright (c) http://weibo.com/luohanchenyilong/ . All rights reserved.
77
//
88
#import <UIKit/UIKit.h>
9+
910
@class FilterHeaderView;
1011
@protocol FilterHeaderViewDelegate <NSObject>
12+
1113
@required
1214
-(void)filterHeaderViewMoreBtnClicked:(id)sender;
15+
1316
@end
1417

1518
#import <UIKit/UIKit.h>
1619
#import "CYLIndexPathButton.h"
1720
#import "CYLRightImageButton.h"
1821

19-
extern float CYLFilterHeaderViewHeigt;
22+
extern const float CYLFilterHeaderViewHeigt;
23+
2024
@interface CYLFilterHeaderView : UICollectionReusableView
25+
2126
@property (nonatomic, strong) CYLIndexPathButton *titleButton;
2227
@property (nonatomic, strong) CYLRightImageButton *moreButton;
2328
@property (nonatomic, weak ) id<FilterHeaderViewDelegate> delegate;
29+
2430
- (void)moreBtnClicked:(id)sender;
2531

2632
@end

CollectionViewClassifyMenu/Class/ClassifyMenu(两级可折叠菜单)/View/CYLFilterHeaderView.m

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,18 @@
77
//
88

99
#import "CYLFilterHeaderView.h"
10-
#define kTitleButtonWidth 250.f
11-
#define kMoreButtonWidth 36*2
12-
#define kCureOfLineHight 0.5
13-
#define kCureOfLineOffX 16
1410

15-
float CYLFilterHeaderViewHeigt = 38;
11+
static float const kTitleButtonWidth = 250.f;
12+
static float const kMoreButtonWidth = 36*2;
13+
static float const kCureOfLineHight = 0.5;
14+
static float const kCureOfLineOffX = 16;
15+
16+
float const CYLFilterHeaderViewHeigt = 38;
17+
1618
@interface CYLFilterHeaderView()
1719

1820
@end
21+
1922
@implementation CYLFilterHeaderView
2023

2124
- (id)initWithFrame:(CGRect)frame
@@ -71,4 +74,5 @@ - (void)moreBtnClicked:(id)sender {
7174
[self.delegate filterHeaderViewMoreBtnClicked:self.moreButton];
7275
}
7376
}
77+
7478
@end

CollectionViewClassifyMenu/Class/ClassifyMenu(两级可折叠菜单)/View/CYLIndexPathButton.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99
#import <UIKit/UIKit.h>
1010

1111
@interface CYLIndexPathButton : UIButton
12+
1213
@property (nonatomic, assign) NSInteger section;
1314
@property (nonatomic, assign) NSInteger row;
15+
1416
@end

CollectionViewClassifyMenu/Class/ClassifyMenu(两级可折叠菜单)/View/CYLIndexPathButton.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#import "CYLIndexPathButton.h"
1010

1111
@implementation CYLIndexPathButton
12+
1213
/**
1314
* 重写高亮状态,让高亮状态不改变样式
1415
*

CollectionViewClassifyMenu/Class/ClassifyMenu(两级可折叠菜单)/View/CYLRightImageButton.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,5 @@
99
#import <UIKit/UIKit.h>
1010

1111
@interface CYLRightImageButton : UIButton
12+
1213
@end

0 commit comments

Comments
 (0)