Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hsd/phrase
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: hsd/phrase
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8.0
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 11 files changed
  • 1 contributor

Commits on May 22, 2018

  1. Initial workable module for version 8.0 

    - model is compatible with previous
- sequence on phraseinfo and phrases, so manual ordering is active
- default form in product template form (tab "Phrases")
- base set in dutch for phrases
    @mrvdb
    mrvdb committed May 22, 2018
    Configuration menu
    Copy the full SHA
    1f1251d View commit details
    Browse the repository at this point in the history

Commits on May 23, 2018

  1. Form redesign 

    - link back to products, so the view from risk perspective makes more
  sense. Editable from two sides.
- redesign phrases form to be more modern
    @mrvdb
    mrvdb committed May 23, 2018
    Configuration menu
    Copy the full SHA
    ff3f4e8 View commit details
    Browse the repository at this point in the history

  2. Mark R- and S-phrases inactive by default 

    They are deprecated legislation.
    @mrvdb
    mrvdb committed May 23, 2018
    Configuration menu
    Copy the full SHA
    7a73b66 View commit details
    Browse the repository at this point in the history

  3. Sort the datafile for easier updating

    @mrvdb
    mrvdb committed May 23, 2018
    Configuration menu
    Copy the full SHA
    cecb171 View commit details
    Browse the repository at this point in the history

  4. Mark R and S phrasetypes inactive and add inactive field to form view

    @mrvdb
    mrvdb committed May 23, 2018
    Configuration menu
    Copy the full SHA
    bf6e4dc View commit details
    Browse the repository at this point in the history

  5. Add direct translation for phrases 

    While perhaps redundant, this is way easier for the 99% case than
going into translations, which is better suited for framework
translation than to value translations.
    @mrvdb
    mrvdb committed May 23, 2018
    Configuration menu
    Copy the full SHA
    1ee41e4 View commit details
    Browse the repository at this point in the history

  6. Remove non standard phrases 

    Requires a safeguard on the server!
    @mrvdb
    mrvdb committed May 23, 2018
    Configuration menu
    Copy the full SHA
    29b5113 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2018

  1. Inital translation files dutch

    @mrvdb
    mrvdb committed May 24, 2018
    Configuration menu
    Copy the full SHA
    303fd65 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2019

  1. Define name on the link data, so searching works 

    _rec_name is defaulting to name, which wasn't in the model. Using a
related definition solves this.

Result: search for contains on code (=name) of the phrases is now possible.
    @mrvdb
    mrvdb committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    146959b View commit details
    Browse the repository at this point in the history
Loading