Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: wbluke/readable-code
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: han16935/readable-code
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 17 commits
  • 38 files changed
  • 1 contributor

Commits on Jul 3, 2024

  1. 메서드 추상화

    @han16935
    han16935 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    b7ca151 View commit details
    Browse the repository at this point in the history

  2. 추상화 레벨 > 메서드 선언 통해 읽는 사람이 부담없이 읽을 수 잇도록, 그리고 추상화 레벨을 맞출 수 잇음

    @han16935
    han16935 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    55f60a1 View commit details
    Browse the repository at this point in the history

  3. 매직 넘버, 매직 스트링 

       - 의미는 가지고 있으나, 아직 상수 취급받지 못한 값들 > 상수 취급이 큰 도움
    @han16935
    han16935 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f83fb38 View commit details
    Browse the repository at this point in the history

  4. early return 

       - else문을 지양해
     if문을 기억하게 하지 않도록 하자!
    @han16935
    han16935 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    9d5e7fa View commit details
    Browse the repository at this point in the history

  5. 사고의 DEPTH 줄이기 

        - for 이중 반복문 등 지양, 변수는 실사용 바로 위에 사용 권장
    @han16935
    han16935 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    2019eb8 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. 공백 라인 + 부정어 사용 

       - 공백 라인을 통해 읽는 사람에게
     더 쉽게 읽게 할 수 잇다

   - !을 사용해 부정어 표시하는 것보다 반대되는 표현이나 (left <-> right) 불가하다면 Not을 사용하는 것이 바람직 (isNotLeftSide())
    @han16935
    han16935 committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    756824f View commit details
    Browse the repository at this point in the history

  2. 예외 처리 

      - NPE가 발생할 수 있는 장소에 대해 엄격히
    처리

  - Optional은 비싼 자원, 사용한다면
    최대한 빨리 해소

  - 개발자가 의도한 예외와 그렇지 않은 예외
    구분하기
    @han16935
    han16935 committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    83d3580 View commit details
    Browse the repository at this point in the history

  3. 객체 설계

    @han16935
    han16935 committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    bac9bd1 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2024

  1. OCP

    @han16935
    han16935 committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    0ce9f76 View commit details
    Browse the repository at this point in the history

  2. 앞 커밋 OCP > SRP (현재가 OCP) 인터페이스 통해 기존 코드가 변하지 않아도 게임 레벨 세팅가능!

    @han16935
    han16935 committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    1124f5a View commit details
    Browse the repository at this point in the history

  3. LSP 위반 코드 > Cell2 상속받은 클래스에서 updateNearbyLandMineCount() 호출 시, 각자 결과가… 

    … 다른 경우 존재
    @han16935
    han16935 committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    1126cc8 View commit details
    Browse the repository at this point in the history

  4. ISP > implements하는 인터페이스에 구현하지 않는 기능이 잇을 경우, 인터페이스를 분리하자

    @han16935
    han16935 committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    c6fbcc5 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. 리팩토링 1

    @han16935
    han16935 committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d47eb53 View commit details
    Browse the repository at this point in the history

  2. [refactor] 일급 컬렉션 이용

    @han16935
    han16935 committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    4c341e6 View commit details
    Browse the repository at this point in the history

  3. [refactor] display() 위치를 OutputHandler로 이전 + 인터페이스 이용

    @han16935
    han16935 committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    ea3a7cf View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. [refactor] 

        - 무엇을 가져올 것인가?와 어떻게 가져올 것인가?는 다름
    @han16935
    han16935 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    8d4647f View commit details
    Browse the repository at this point in the history

  2. [refactor] 

        - method 추출 및 매직 넘버, 스트링 처리
    @han16935
    han16935 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    34cc7d2 View commit details
    Browse the repository at this point in the history
Loading