Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: joaks1/python-script-best-practice
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ginalamka/python-script-best-practice
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 1 file changed
  • 1 contributor

Commits on Mar 3, 2021

  1. best practice 1

    I put the codes into functions. script currently works!
    ginalamka committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    74bad0c View commit details
    Browse the repository at this point in the history
  2. part of best practice 2

    I have gone through and worked on the script for best practice #2. I am not sure that this is currently working, as the output gives an error, not an integer. I have looked through the code a few times and cant seem to see the problem. I have run out of time and it is time for me to take Charlie for a walk. I will do this another time when I have more patience than I do now...
    ginalamka committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    6e90347 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. best practice 2 complete!

    there was a problem with the indent within the if __name__ == '__main__'
    function. This has been resolved. Using fresh eyes to check for errors definitely helped (plus the sunshine!). Cheers
    ginalamka committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    53037d4 View commit details
    Browse the repository at this point in the history
  2. best practice 3!

    I have added a doc string to the best practices activity. this adds information into the help function.
    ginalamka committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    3c5bde0 View commit details
    Browse the repository at this point in the history
  3. best practice 4 finished!

    In this, I added in examples in the doc string to help the user in the future. Running the examples as tests help confirm that the function is working as expected-- which it is!
    ginalamka committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    6a3b295 View commit details
    Browse the repository at this point in the history
Loading