Skip to content
This repository was archived by the owner on Jun 17, 2021. It is now read-only.
This repository was archived by the owner on Jun 17, 2021. It is now read-only.

Webpack bundle paths in toolbox.json - format is not consistant with other configs #16

@tonifisler

Description

@tonifisler

I joyfully set up the multiple Webpack bundles configuration like this:

  "bundles": {
    "js": [
      {
        "name": "credit",
        "src": "web/themes/wd/assets/components/molecules/credit/credit.js"
      },
      {
        "name": "app",
        "src": "web/themes/wd/assets/components/base.js"
      }
    ]
  }

And the build doesn't crash anything and just continues building the app bundle as if nothing was wrong.

I should have written a path relative to the src value:

  "bundles": {
    "js": [
      {
        "name": "credit",
        "src": "components/molecules/credit/credit.js"
      },
      {
        "name": "app",
        "src": "components/base.js"
      }
    ]
  }

Since all the paths in toolbox.json are written from the project root, I never imagined that was the wrong thing to do:

  "images": [
    "web/themes/wd/build/images/**/*"
  ],

So, we should either keep it like this (and then document why the path is relative to src), or change this to be consistent with the rest of the config. Cheers!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions