Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Descantly/require-from-string
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: floatdrop/require-from-string
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 19 commits
  • 5 files changed
  • 8 contributors

Commits on May 2, 2016

  1. Default filename to empty string 

    Node v6 throws if the input to `path` functions are not strings. See [here](https://github.com/nodejs/node/wiki/Breaking-changes-between-v5-and-v6#path).
    @eligolding
    eligolding committed May 2, 2016
    Configuration menu
    Copy the full SHA
    1aa7619 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2016

  1. Add Node.JS 6.x to tests

    @floatdrop
    floatdrop committed May 3, 2016
    Configuration menu
    Copy the full SHA
    f797ee0 View commit details
    Browse the repository at this point in the history

  2. Merge pull request floatdrop#5 from eligolding/patch-1 

    Node v6 support. Default filename to empty string.
    @floatdrop
    floatdrop committed May 3, 2016
    Configuration menu
    Copy the full SHA
    85367a2 View commit details
    Browse the repository at this point in the history

  3. add test and fix readme for filename

    @floatdrop
    floatdrop committed May 3, 2016
    Configuration menu
    Copy the full SHA
    60f5969 View commit details
    Browse the repository at this point in the history

  4. 1.2.0

    @floatdrop
    floatdrop committed May 3, 2016
    Configuration menu
    Copy the full SHA
    8610539 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2016

  1. Require 'module' instead of referencing constructor

    @richardscarrott
    richardscarrott committed Oct 1, 2016
    Configuration menu
    Copy the full SHA
    80783b2 View commit details
    Browse the repository at this point in the history

  2. Merge pull request floatdrop#6 from 60frames/module 

    Require 'module' instead of referencing constructor
    @floatdrop
    floatdrop authored Oct 1, 2016
    Configuration menu
    Copy the full SHA
    8561059 View commit details
    Browse the repository at this point in the history

  3. 1.2.1

    @floatdrop
    floatdrop committed Oct 1, 2016
    Configuration menu
    Copy the full SHA
    b81e995 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2017

  1. add Node.JS 7 to tests 

    and remove 0.10 and 0.12
    @floatdrop
    floatdrop authored Mar 6, 2017
    Configuration menu
    Copy the full SHA
    3cf2b66 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2017

  1. Cleanup module.children after evaluating 

    Without this, required-from-string module never gets garbage collected,
even when exports value is no longer used.
    Sergey Tatarintsev committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    ca2b81f View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2017

  1. Merge pull request floatdrop#9 from researchgate/fix/cleanup-children 

    Cleanup module.children after evaluating
    @floatdrop
    floatdrop authored Sep 16, 2017
    Configuration menu
    Copy the full SHA
    6571b79 View commit details
    Browse the repository at this point in the history

  2. 2.0.0

    @floatdrop
    floatdrop committed Sep 16, 2017
    Configuration menu
    Copy the full SHA
    ce8ae31 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2017

  1. Check parent.children before splice, accommodate jest 

    When used with jest, `parent.children` will be undefined.
`console.log(module)`:
{ exports: [Function: requireFromString],
      filename: 'E:/Projects/repos/cosmiconfig/node_modules/require-from-string/index.js',
      id: 'E:/Projects/repos/cosmiconfig/node_modules/require-from-string/index.js',
      children: [],
      parent: { exports: {}, filename: 'mock.js', id: 'mockParent' },
      paths:
       [ 'E:/Projects/repos/cosmiconfig/node_modules/require-from-string/node_modules',
         'E:/Projects/repos/cosmiconfig/node_modules/node_modules',
         'E:/Projects/repos/cosmiconfig/node_modules',
         'E:/Projects/repos/node_modules',
         'E:/Projects/node_modules',
         'E:/node_modules' ],
      require:
       { [Function: bound requireModuleOrMock]
         cache: {},
         extensions: {},
         requireActual: [Function: bound requireModule],
         requireMock: [Function: bound requireMock],
         resolve: [Function] } }
    @sudo-suhas
    sudo-suhas committed Sep 17, 2017
    Configuration menu
    Copy the full SHA
    a407c5d View commit details
    Browse the repository at this point in the history

  2. Merge pull request floatdrop#10 from sudo-suhas/check-before-splice 

    Check parent.children before splice, accommodate jest
    @floatdrop
    floatdrop authored Sep 17, 2017
    Configuration menu
    Copy the full SHA
    c8b4a97 View commit details
    Browse the repository at this point in the history

  3. 2.0.1

    @floatdrop
    floatdrop committed Sep 17, 2017
    Configuration menu
    Copy the full SHA
    cbe9197 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2018

  1. correct typo: appendPath -> appendPaths

    @joehua87
    joehua87 authored Jan 12, 2018
    Configuration menu
    Copy the full SHA
    696db02 View commit details
    Browse the repository at this point in the history

  2. Merge pull request floatdrop#15 from joehua87/patch-1 

    correct typo: appendPath -> appendPaths
    @floatdrop
    floatdrop authored Jan 12, 2018
    Configuration menu
    Copy the full SHA
    7fc0ab7 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2018

  1. Handle if module.parent is undefined (floatdrop#20)

    @chinesedfan @floatdrop
    chinesedfan authored and floatdrop committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    150ccdf View commit details
    Browse the repository at this point in the history

  2. 2.0.2

    @floatdrop
    floatdrop committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    d1575a4 View commit details
    Browse the repository at this point in the history
Loading