Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NomicFoundation/hardhat
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: ericliujt/hardhat
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 14 commits
  • 35 files changed
  • 4 contributors

Commits on Aug 16, 2025

  1. add documentation feedback

    @ericliujt
    ericliujt committed Aug 16, 2025
    Configuration menu
    Copy the full SHA
    f74e1c3 View commit details
    Browse the repository at this point in the history

  2. Initial implementation of hardhat-ledger plugin (currently failing) (#1) 

    * initial project

Signed-off-by: Andrew Tretyakov <42178850+0xAndoroid@users.noreply.github.com>

* update git ignore

Signed-off-by: Andrew Tretyakov <42178850+0xAndoroid@users.noreply.github.com>

---------

Signed-off-by: Andrew Tretyakov <42178850+0xAndoroid@users.noreply.github.com>
    @0xAndoroid
    0xAndoroid authored Aug 16, 2025
    Configuration menu
    Copy the full SHA
    33f04a2 View commit details
    Browse the repository at this point in the history

  3. add documentation feedback

    @ericliujt
    ericliujt committed Aug 16, 2025
    Configuration menu
    Copy the full SHA
    5b70966 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #2 from ericliujt/erc/improvements 

    chore: added documentation feedback for Ledger documentation
    @ericliujt
    ericliujt authored Aug 16, 2025
    Configuration menu
    Copy the full SHA
    c0bab68 View commit details
    Browse the repository at this point in the history

  5. format change

    @ericliujt
    ericliujt committed Aug 16, 2025
    Configuration menu
    Copy the full SHA
    4aec1fb View commit details
    Browse the repository at this point in the history

  6. Merge pull request #3 from ericliujt/erc/impv2 

    format change
    @ericliujt
    ericliujt authored Aug 16, 2025
    Configuration menu
    Copy the full SHA
    17d5a7d View commit details
    Browse the repository at this point in the history

  7. Addresses are discoverable. (#5) 

    * implement dmk

Signed-off-by: Andrew Tretyakov <42178850+0xAndoroid@users.noreply.github.com>

* tests and build fixes

Signed-off-by: Andrew Tretyakov <42178850+0xAndoroid@users.noreply.github.com>

* fix build issues and examples

Signed-off-by: Andrew Tretyakov <42178850+0xAndoroid@users.noreply.github.com>

* getting the addresses from ledger.

Signed-off-by: Andrew Tretyakov <42178850+0xAndoroid@users.noreply.github.com>

---------

Signed-off-by: Andrew Tretyakov <42178850+0xAndoroid@users.noreply.github.com>
    @0xAndoroid
    0xAndoroid authored Aug 16, 2025
    Configuration menu
    Copy the full SHA
    5071dde View commit details
    Browse the repository at this point in the history

  8. update documentation

    @ericliujt
    ericliujt committed Aug 16, 2025
    Configuration menu
    Copy the full SHA
    a3fcd92 View commit details
    Browse the repository at this point in the history

  9. signing works 

    Signed-off-by: Andrew Tretyakov <42178850+0xAndoroid@users.noreply.github.com>
    @0xAndoroid
    0xAndoroid committed Aug 16, 2025
    Configuration menu
    Copy the full SHA
    6b12a18 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'signing'

    @0xAndoroid
    0xAndoroid committed Aug 16, 2025
    Configuration menu
    Copy the full SHA
    203a549 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2025

  1. example project 

    Signed-off-by: Andrew Tretyakov <42178850+0xAndoroid@users.noreply.github.com>
    @0xAndoroid
    0xAndoroid committed Aug 17, 2025
    Configuration menu
    Copy the full SHA
    c9c0abc View commit details
    Browse the repository at this point in the history

  2. clean up debugging code 

    Signed-off-by: Andrew Tretyakov <42178850+0xAndoroid@users.noreply.github.com>
    @0xAndoroid
    0xAndoroid committed Aug 17, 2025
    Configuration menu
    Copy the full SHA
    1de5ced View commit details
    Browse the repository at this point in the history

  3. fix tests 

    Signed-off-by: Andrew Tretyakov <42178850+0xAndoroid@users.noreply.github.com>
    @0xAndoroid
    0xAndoroid committed Aug 17, 2025
    Configuration menu
    Copy the full SHA
    08376fb View commit details
    Browse the repository at this point in the history

  4. update improvements file 

    Signed-off-by: Andrew Tretyakov <42178850+0xAndoroid@users.noreply.github.com>
    @0xAndoroid
    0xAndoroid committed Aug 17, 2025
    Configuration menu
    Copy the full SHA
    5f5eaaa View commit details
    Browse the repository at this point in the history
Loading