This repository was archived by the owner on Nov 27, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: angular/angular-phonecat
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: diffley/angular-phonecat
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 15 commits
- 23 files changed
- 3 contributors
Commits on Nov 21, 2016
-
- Add the 'angular.js' script. - Add the `ngApp` directive to bootstrap the application. - Add a simple template with an expression.
Configuration menu - View commit details
-
Copy full SHA for b160462 - Browse repository at this point
Copy the full SHA b160462View commit details -
- Add a stylesheet file ('app/app.css'). - Add a static list with two phones.Configuration menu - View commit details
-
Copy full SHA for 30fd06f - Browse repository at this point
Copy the full SHA 30fd06fView commit details -
- Convert the static phone list to dynamic by: - Creating a `PhoneListController` controller. - Extracting the data from HTML into the controller as an in-memory dataset. - Converting the static document into a template with the use of the `ngRepeat` directive. - Add a simple unit test for the `PhoneListController` controller to show how to write tests and run them using Karma (see README.md for instructions).
Configuration menu - View commit details
-
Copy full SHA for 3867471 - Browse repository at this point
Copy the full SHA 3867471View commit details -
- Introduce components. - Combine the controller and the template into a reusable, isolated `phoneList` component. - Refactor the application and tests to use the `phoneList` component.
Configuration menu - View commit details
-
Copy full SHA for c1ca5d0 - Browse repository at this point
Copy the full SHA c1ca5d0View commit details -
step-4 Directory and File Organization
- Refactor the layout of files and directories, applying best practices and techniques that will make the application easier to maintain and expand in the future: - Put each entity in its own file. - Organize code by feature area (instead of by function). - Split code into modules that other modules can depend on. - Use external templates in `.html` files (instead of inline HTML strings).
Configuration menu - View commit details
-
Copy full SHA for dc86082 - Browse repository at this point
Copy the full SHA dc86082View commit details -
- Add a search box to demonstrate: - How the data-binding works on input fields. - How to use the `filter` filter. - How `ngRepeat` automatically shrinks and grows the number of phones in the view. - Add an end-to-end test to: - Show how end-to-end tests are written and used. - Prove that the search box and the repeater are correctly wired together.
Configuration menu - View commit details
-
Copy full SHA for c2ca489 - Browse repository at this point
Copy the full SHA c2ca489View commit details -
- Add an `age` property to the phone model. - Add a drop-down menu to control the phone list order. - Override the default order value in controller. - Add unit and end-to-end tests for this feature. Closes #213
Configuration menu - View commit details
-
Copy full SHA for 7e60b73 - Browse repository at this point
Copy the full SHA 7e60b73View commit details -
step-7 XHR & Dependency Injection
- Replace the in-memory dataset with data loaded from the server (in the form of a static 'phone.json' file to keep the tutorial backend agnostic): - The JSON data is loaded using the `$http` service. - Demonstrate the use of `services` and `dependency injection` (DI): - `$http` is injected into the controller through DI. - Introduce DI annotation methods: `.$inject` and inline array Closes #207
Configuration menu - View commit details
-
Copy full SHA for 9b1ee8f - Browse repository at this point
Copy the full SHA 9b1ee8fView commit details -
step-8 Templating Links & Images
- Add a phone image and links to phone pages. - Add an end-to-end test that verifies the phone links. - Tweak the CSS to style the page just a notch.
Configuration menu - View commit details
-
Copy full SHA for baf5a9b - Browse repository at this point
Copy the full SHA baf5a9bView commit details -
step-9 Routing & Multiple Views
- Introduce the `$route` service, which allows binding URLs to views for routing and deep-linking: - Add the `ngRoute` module as a dependency. - Configure routes for the application. - Use the `ngView` directive in 'index.html'. - Create a phone list route (`/phones`): - Map `/phones` to the existing `phoneList` component. - Create a phone detail route (`/phones/:phoneId`): - Map `/phones/:phoneId` to a new `phoneDetail` component. - Create a dummy `phoneDetail` component, which displays the selected phone ID. - Pass the `phoneId` parameter to the component's controller via `$routeParams`.
Configuration menu - View commit details
-
Copy full SHA for 53d9314 - Browse repository at this point
Copy the full SHA 53d9314View commit details -
- Implement fetching data for the selected phone and rendering to the view: - Use `$http` in `PhoneDetailController` to fetch the phone details from a JSON file. - Create the template for the detail view. - Add CSS styles to make the phone detail page look "pretty-ish".
Configuration menu - View commit details
-
Copy full SHA for 4b67b04 - Browse repository at this point
Copy the full SHA 4b67b04View commit details -
- Implement a custom `checkmark` filter. - Update the `phoneDetail` template to use the `checkmark` filter. - Add a unit test for the `checkmark` filter.
Configuration menu - View commit details
-
Copy full SHA for aeefb7c - Browse repository at this point
Copy the full SHA aeefb7cView commit details -
- Make the thumbnail images in the phone detail view clickable: - Introduce a `mainImageUrl` property on `PhoneDetailController`. - Implement the `setImage()` method for changing the main image. - Use `ngClick` on the thumbnails to register a handler that changes the main image. - Add an end-to-end test for this feature.
Configuration menu - View commit details
-
Copy full SHA for b535c42 - Browse repository at this point
Copy the full SHA b535c42View commit details -
step-13 REST and Custom Services
- Replace `$http` with `$resource`. - Create a custom `Phone` service that represents the RESTful client. - Use a custom Jasmine equality tester in unit tests to ignore irrelevant properties.
Configuration menu - View commit details
-
Copy full SHA for 7122fc7 - Browse repository at this point
Copy the full SHA 7122fc7View commit details -
- Add animations to the application: - Animate changes to the phone list, adding, removing and reordering phones with `ngRepeat`. - Animate view transitions with `ngView`. - Animate changes to the main phone image in the phone detail view. - Showcase three different kinds of animations: - CSS transition animations. - CSS keyframe animations. - JavaScript-based animations.
Configuration menu - View commit details
-
Copy full SHA for 0970e05 - Browse repository at this point
Copy the full SHA 0970e05View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master