Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: atom/atom
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: darwin/atom
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Sep 24, 2015

  1. 🐛 fix atom.isValidDimensions under Mac (fixes #7555, fixes #8909) 

    Additionally I have also:
* added logging when detected invalid dimensions
* changed logic for determining width and height after recovery from invalid dimensions

Original implementation was not symmetric. And I believe Math.min was a mistake. Original intent probably was to use Math.max instead.
It didn't guard against case of generating invalid width if screen.getPrimaryDisplay().workAreaSize returned 0 or some negative value.
And it was clamping width for displays wider than 1024 which makes little sense.

New implementation makes sure width is at least 1024 and height is at least 512 after reset.
    @darwin
    darwin committed Sep 24, 2015
    1 Configuration menu
    Copy the full SHA
    7dc06de View commit details
    Browse the repository at this point in the history

  2. remove questionable test

    @darwin
    darwin committed Sep 24, 2015
    Configuration menu
    Copy the full SHA
    8d7bc34 View commit details
    Browse the repository at this point in the history

  3. remove trailing whitespace

    @darwin
    darwin committed Sep 24, 2015
    Configuration menu
    Copy the full SHA
    7f934d3 View commit details
    Browse the repository at this point in the history
Loading