-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Open
Labels
area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.gardeningtriagedIssue has been triaged by sub teamIssue has been triaged by sub team
Description
starting with https://dart.googlesource.com/sdk/+/2c715e92b66e108c1ee5bf837ff4a5c5860dce40
--- Command "vm" (took 27.000350s):
DART_CONFIGURATION=ReleaseARM64 out/ReleaseARM64/dart-sdk/bin/dart --enable_asserts -Dtest_runner.configuration=unittest-asserts-release-linux-arm64 --ignore-unrecognized-flags --packages=/b/s/w/ir/.dart_tool/package_config.json /b/s/w/ir/pkg/vm_snapshot_analysis/test/instruction_sizes_test.dart
exit code:
255
stdout:
00:00 �[32m+0�[0m: no-size-impact --print_instructions_sizes_to�[0m
00:02 �[32m+1�[0m: no-size-impact --write_v8_snapshot_profile_to�[0m
00:04 �[32m+2�[0m: instruction-sizes basic-parsing�[0m
00:05 �[32m+3�[0m: instruction-sizes program-info-from-sizes�[0m
00:06 �[32m+4�[0m: instruction-sizes histograms�[0m
00:07 �[32m+5�[0m: instruction-sizes histograms-filter�[0m
00:08 �[32m+6�[0m: instruction-sizes diff�[0m
00:10 �[32m+7�[0m: instruction-sizes diff-collapsed�[0m
00:12 �[32m+8�[0m: v8-profile program-info-from-profile�[0m
00:13 �[32m+9�[0m: v8-profile instruction ownership is preserved�[0m
00:16 �[32m+10�[0m: v8-profile histograms�[0m
00:17 �[32m+11�[0m: v8-profile diff�[0m
00:19 �[32m+12�[0m: v8-profile diff-collapsed�[0m
00:22 �[32m+12�[0m�[31m -1�[0m: v8-profile diff-collapsed �[1m�[31m[E]�[0m�[0m
Expected: {
'package:input': {
'#type': 'package',
'package:input/input.dart': {
'#type': 'library',
'::': {
'#type': 'class',
'makeSomeClosures': {
'#type': 'function',
'#size': <a value less than <0>>,
'<anonymous closure>': {'#type': 'function', '#size': <a value less than <0>>}
}
}
}
}
}
Actual: {
'package:input': {
'package:input/input.dart': {
'::': {
'makeSomeClosures': {
'<anonymous closure>': {'#size': -261, '#type': 'function'},
'#type': 'function'
},
'#type': 'class'
},
'#type': 'library'
},
'#type': 'package'
}
}
Which: at location ['package:input']['package:input/input.dart']['::']['makeSomeClosures'] is {
'<anonymous closure>': {'#size': -261, '#type': 'function'},
'#type': 'function'
} which has different length and is missing map key '#size'
package:matcher/src/expect/expect.dart 187:31 fail
package:matcher/src/expect/expect.dart 182:3 _expect
package:matcher/src/expect/expect.dart 65:3 expect
pkg/vm_snapshot_analysis/test/instruction_sizes_test.dart 798:11 main.<fn>.<fn>.<fn>.<fn>
===== asynchronous gap ===========================
pkg/vm_snapshot_analysis/test/utils.dart 98:5 withFlagImpl.<fn>
===== asynchronous gap ===========================
pkg/vm_snapshot_analysis/test/utils.dart 109:5 withTempDir
===== asynchronous gap ===========================
pkg/vm_snapshot_analysis/test/instruction_sizes_test.dart 789:9 main.<fn>.<fn>.<fn>
===== asynchronous gap ===========================
pkg/vm_snapshot_analysis/test/utils.dart 98:5 withFlagImpl.<fn>
===== asynchronous gap ===========================
pkg/vm_snapshot_analysis/test/utils.dart 109:5 withTempDir
===== asynchronous gap ===========================
pkg/vm_snapshot_analysis/test/instruction_sizes_test.dart 788:7 main.<fn>.<fn>
===== asynchronous gap ===========================
package:test_api/src/backend/declarer.dart 253:15 Declarer.test.<fn>.<fn>
===== asynchronous gap ===========================
package:test_api/src/backend/declarer.dart 250:11 Declarer.test.<fn>
===== asynchronous gap ===========================
package:test_api/src/backend/invoker.dart 318:9 Invoker._waitForOutstandingCallbacks.<fn>
00:22 �[32m+12�[0m�[31m -1�[0m: v8-profile treemap�[0m
00:23 �[32m+13�[0m�[31m -1�[0m: v8-profile dominators�[0m
00:24 �[32m+14�[0m�[31m -1�[0m: �[31mSome tests failed.�[0m
Consider enabling the flag chain-stack-traces to receive more detailed exceptions.
For example, 'dart test --chain-stack-traces'.
stderr:
Unhandled exception:
Dummy exception to set exit code.
--- Re-run this test:
python3 tools/test.py -n unittest-asserts-release-linux-arm64 pkg/vm_snapshot_analysis/test/instruction_sizes_test
Metadata
Metadata
Assignees
Labels
area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.gardeningtriagedIssue has been triaged by sub teamIssue has been triaged by sub team