Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openscenegraph/OpenSceneGraph
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: dan-t/OpenSceneGraph
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Jan 29, 2019

  1. OcclusionQueryNode: add more debug output

    @dan-t
    dan-t committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    7b7b403 View commit details
    Browse the repository at this point in the history

  2. OcclusionQueryNode: ensure a valid query geometry 

    In the case of an invalid geometry there're two ways
to react on it, traverse the subgraph or not traversing it.

In the case of an invalid query box from e.g. a geometry
with a cleared DrawElements list, not traversing the
subgraph would be the right thing.

But if the geometry only consists of e.g. one point, then
the query box would be always invalid and the subgraph never
traversed.

So it seems safer to always traverse the subgraph, which
is done in this patch.
    @dan-t
    dan-t committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    8b7cdf1 View commit details
    Browse the repository at this point in the history

  3. OcclusionQueryNode: reset the test result of the invalid geometry 

    There're cases that the occlusion test result has been retrieved
after the query geometry has been changed, it's the result of the
geometry before the change.
    @dan-t
    dan-t committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    d7472d9 View commit details
    Browse the repository at this point in the history
Loading