Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: php/php-src
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: dagelf/php-src
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 2 files changed
  • 1 contributor

Commits on Feb 21, 2017

  1. Update Makefile.frag 

    By default php-fpm.d/* is included in the config. Writing anything there will break most existing PHP applications. 

Also, $(INSTALL_DATA) won't return unnecessary errors, so don't ignore them. If installation of something is part of make install, and it doesn't happen, it should fail. ( || : at the end removed)
    @dagelf
    dagelf authored Feb 21, 2017
    Configuration menu
    Copy the full SHA
    3ec6271 View commit details
    Browse the repository at this point in the history

  2. Update Makefile.frag 

    Edited in github editor... changed spaces to tabs
    @dagelf
    dagelf authored Feb 21, 2017
    Configuration menu
    Copy the full SHA
    3f3d749 View commit details
    Browse the repository at this point in the history

  3. Update Makefile.frag 

    Missed some spaces for the tab-nazi
    @dagelf
    dagelf authored Feb 21, 2017
    Configuration menu
    Copy the full SHA
    1b08ad0 View commit details
    Browse the repository at this point in the history

  4. Update Makefile.global 

    One space too many
    @dagelf
    dagelf authored Feb 21, 2017
    Configuration menu
    Copy the full SHA
    d1b5639 View commit details
    Browse the repository at this point in the history

  5. Update Makefile.frag 

    Build error messages aren't very clear. Trying to figure out build environment and getting it to build without ignoring the shtool install errors...
    @dagelf
    dagelf authored Feb 21, 2017
    Configuration menu
    Copy the full SHA
    f57ba0b View commit details
    Browse the repository at this point in the history
Loading