Skip to content

Commit 95f3af0

Browse files
committed
NETTY-418 isCompleteFailure() and isCompleteSuccess() are both true at the same time
* Fixed incorrect isPartialSuccess(), isPartialFailure(), isCompleteFailure() implementation
1 parent acb1ac8 commit 95f3af0

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/main/java/org/jboss/netty/channel/group/DefaultChannelGroupFuture.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,17 +152,18 @@ public synchronized boolean isCompleteSuccess() {
152152

153153
@Override
154154
public synchronized boolean isPartialSuccess() {
155-
return !futures.isEmpty() && successCount != 0;
155+
return successCount != 0 && successCount != futures.size();
156156
}
157157

158158
@Override
159159
public synchronized boolean isPartialFailure() {
160-
return !futures.isEmpty() && failureCount != 0;
160+
return failureCount != 0 && failureCount != futures.size();
161161
}
162162

163163
@Override
164164
public synchronized boolean isCompleteFailure() {
165-
return failureCount == futures.size();
165+
int futureCnt = futures.size();
166+
return futureCnt != 0 && failureCount == futureCnt;
166167
}
167168

168169
@Override

0 commit comments

Comments
 (0)