Skip to content

Commit 6f7d2f4

Browse files
committed
NETTY-417 client channel still open after close and wait
* Fixed a bug in SslHandler where a write attempt made after SSLEngine is closed result in unnotified future. Fixed by respecting the case where SslEngineResult.Status == CLOSED
1 parent c6fa827 commit 6f7d2f4

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/main/java/org/jboss/netty/handler/ssl/SslHandler.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -659,6 +659,11 @@ private ChannelFuture wrap(ChannelHandlerContext context, Channel channel)
659659
channel, future, msg, channel.getRemoteAddress());
660660
offerEncryptedWriteRequest(encryptedWrite);
661661
offered = true;
662+
} else if (result.getStatus() == Status.CLOSED) {
663+
// SSLEngine has been closed already.
664+
// Any further write attempts should be denied.
665+
success = false;
666+
break;
662667
} else {
663668
final HandshakeStatus handshakeStatus = result.getHandshakeStatus();
664669
handleRenegotiation(handshakeStatus);

0 commit comments

Comments
 (0)