-
Notifications
You must be signed in to change notification settings - Fork 489
Comparing changes
Open a pull request
base repository: ros2/rclcpp
base: iron
head repository: cellumation/rclcpp
compare: iron
- 9 commits
- 17 files changed
- 2 contributors
Commits on Oct 27, 2023
-
fix: Fixed race condition in action server between is_ready and take_…
…data and execute Some background information: is_ready, take_data and execute data may be called from different threads in any order. The code in the old state expected them to be called in series, without interruption. This lead to multiple race conditions, as the state of the pimpl objects was altered by the three functions in a non thread safe way. This commit fixed this by - Introducing a data queue that is filled in is_ready - take_data from now only pops the front element of the data queue - A backlog of events if held in num_unreported_events_ which will be reported by future calls of is_ready Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
Configuration menu - View commit details
-
Copy full SHA for 4d3ec4b - Browse repository at this point
Copy the full SHA 4d3ec4bView commit details -
fix(rclcpp_action): Fixed race condition in Client
Some background information: is_ready, take_data and execute data may be called from different threads in any order. The code in the old state expected them to be called in series, without interruption. This lead to multiple race conditions, as the state of the pimpl objects was altered by the three functions in a non thread safe way. This commit fixed this by - Introducing a data queue that is filled in is_ready - take_data from now only pops the front element of the data queue - A backlog of events if held in num_unreported_events_ which will be reported by future calls of is_ready Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
Configuration menu - View commit details
-
Copy full SHA for 0becc43 - Browse repository at this point
Copy the full SHA 0becc43View commit details -
chore: made race condition fix ABI and API compatible
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
Configuration menu - View commit details
-
Copy full SHA for 7e9680e - Browse repository at this point
Copy the full SHA 7e9680eView commit details -
fix(rcl_cpp_action) : fixed regression
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
Configuration menu - View commit details
-
Copy full SHA for b5fe7f9 - Browse repository at this point
Copy the full SHA b5fe7f9View commit details -
feat(Client): Added function to drop a goal handle in a thread safe way
This function allows us to drop the handle in a locked context. If we do not do this within a lock, there will be a race condition between the deletion of the shared_ptr of the handle and the result / feedback callbacks. Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
Configuration menu - View commit details
-
Copy full SHA for 4a1f116 - Browse repository at this point
Copy the full SHA 4a1f116View commit details -
!fix(Client): Do not hold goal_handle ptr if result cb is set.
The capture of the lambda held an copy of the shared_ptr to the goal handle. This lead to the behavior that the goal callbacks would be called, even though the user dropped the handle. Note, this will break the current tutorial, as it restores the documented behavior that a goal will be invalidated as soon as one drops the handle. Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
Configuration menu - View commit details
-
Copy full SHA for a8a2cc3 - Browse repository at this point
Copy the full SHA a8a2cc3View commit details -
Use rcl_timer_call_with_info instead if rcl_timer_call in Timer and a…
…dd interface for a callback with TimerInfo argument Signed-off-by: Alexis Tsogias <a.tsogias@cellumation.com>
Configuration menu - View commit details
-
Copy full SHA for fb7c28b - Browse repository at this point
Copy the full SHA fb7c28bView commit details -
fix: Make passing of timer data thread safe
Janosch Machowinski authored and Janosch Machowinski committedOct 27, 2023 Configuration menu - View commit details
-
Copy full SHA for 49b1f15 - Browse repository at this point
Copy the full SHA 49b1f15View commit details
Commits on Dec 7, 2023
-
feat(MultiThreadedExecutor): Added ability to handle exceptions from …
…threads This commit adds external exception handling for the worker threads, allowing application code to implement custom exception handling.
Configuration menu - View commit details
-
Copy full SHA for 5696e97 - Browse repository at this point
Copy the full SHA 5696e97View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff iron...iron