refactored followers activity

Author: bad6e

app/models/user.rb

@@ -5,6 +5,7 @@ def self.find_or_create_from_oauth(oauth)
     user.nickname   = oauth.info.nickname
     user.image_url  = oauth.info.image
     user.token      = oauth.credentials.token
+    user.followers  =
     user.save
 
     user

app/presenters/github_presenter.rb

@@ -9,26 +9,24 @@ def initialize(user)
 
   def repos
     repos = service.find_user_repos(user).map {|data| build_object(data)}
-    repo_name = repos.map {|repo| repo.name }
-    repo_name
+    repo_names = repos.map {|repo| repo.name }
   end
 
+  #This who is following the user
   def followers
     list = service.find_followers(user).map {|data| build_object(data)}
     followers = list.map {|follower| follower.login}
-    followers
   end
 
+  #This is who the user follows
   def followees
     list = service.find_user_follows(user).map {|data| build_object(data)}
     followees = list.map {|followee| followee.login}
-    followees
   end
 
   def organizations
     list = service.find_user_organizations(user).map {|data| build_object(data)}
     organizations = list.map {|organization| organization.login }
-    organizations
   end
 
   def year_commits
@@ -58,7 +56,7 @@ def followers_activities
 
   private
 
-  def build_object(data)
-    OpenStruct.new(data)
-  end
+    def build_object(data)
+      OpenStruct.new(data)
+    end
 end

app/services/github_service.rb

@@ -11,12 +11,14 @@ def find_user_repos(user)
     parse(connection.get("users/#{user.nickname}/repos"))
   end
 
+  #This who is following the user
   def find_followers(user)
     parse(connection.get("users/#{user.nickname}/followers"))
   end
 
+  #This is who the user follows
   def find_user_follows(user)
-    parse(connection.get("users/#{user.nickname}/following"))
+    @follows ||= parse(connection.get("users/#{user.nickname}/following"))
   end
 
   def find_user_organizations(user)
@@ -52,19 +54,15 @@ def followers_commit_message(name)
     events    = list.select { |item| item[:type] == "PushEvent" }
     commits   = events.map{ |event| event[:payload][:commits] }.flatten!
     messages  = commits.collect{ |commit|  commit[:message] }
+    messages[0..2]
   end
 
   def followers_activity(user)
-    list = find_followers(user)
-    names = list.collect {|item| item[:login] }
+    names = @follows.collect {|item| item[:login] }
     messages = names.map do |name|
       followers_commit_message(name)
     end
-    limited_messages = messages.map do |m|
-      m[0..2]
-    end
-    final = names.zip(limited_messages)
-    final
+    final = names.zip(messages)
   end
 
   def parse(response)