refactor: use AWS SDK v3-style error handling (#3659)

Author: hassy

packages/artillery/lib/platform/aws-ecs/legacy/run-cluster.js

@@ -6,7 +6,9 @@ const {
   StopTaskCommand,
   DescribeTaskDefinitionCommand,
   RegisterTaskDefinitionCommand,
-  DeregisterTaskDefinitionCommand
+  DeregisterTaskDefinitionCommand,
+  InvalidParameterException,
+  ThrottlingException
 } = require('@aws-sdk/client-ecs');
 const {
   SQSClient,
@@ -15,7 +17,7 @@ const {
   ListQueuesCommand,
   GetQueueAttributesCommand
 } = require('@aws-sdk/client-sqs');
-const { GetObjectCommand } = require('@aws-sdk/client-s3');
+const { GetObjectCommand, NoSuchKey } = require('@aws-sdk/client-s3');
 const { IAMClient, GetRoleCommand } = require('@aws-sdk/client-iam');
 // Normal debugging for messages, summaries, and errors:
 const debug = require('debug')('commands:run-test');
@@ -762,7 +764,7 @@ async function tryRunCluster(scriptPath, options, artilleryReporter) {
       debug(context.testId, 'done');
     } catch (err) {
       debug(err);
-      if (err.code === 'InvalidParameterException') {
+      if (err instanceof InvalidParameterException) {
         if (
           err.message
             .toLowerCase()
@@ -1353,7 +1355,7 @@ async function getManifest(context) {
 
     return context;
   } catch (err) {
-    if (err.code === 'NoSuchKey') {
+    if (err instanceof NoSuchKey) {
       throw new TestNotFoundError();
     } else {
       throw err;
@@ -1662,7 +1664,7 @@ async function ecsRunTask(context) {
         throw new Error('Not enough ECS capacity');
       }
     } catch (runErr) {
-      if (runErr.code === 'ThrottlingException') {
+      if (runErr instanceof ThrottlingException) {
         artillery.log('ThrottlingException returned from ECS, retrying');
         await sleep(2000 * retries);
         debug('runTask throttled, retrying');

packages/artillery/lib/platform/aws-lambda/index.js

@@ -14,7 +14,9 @@ const {
   GetFunctionConfigurationCommand,
   InvokeCommand,
   CreateFunctionCommand,
-  DeleteFunctionCommand
+  DeleteFunctionCommand,
+  ResourceConflictException,
+  ResourceNotFoundException
 } = require('@aws-sdk/client-lambda');
 const { PutObjectCommand } = require('@aws-sdk/client-s3');
 const { SQSClient, DeleteQueueCommand } = require('@aws-sdk/client-sqs');
@@ -623,7 +625,7 @@ class PlatformLambda {
       });
       return;
     } catch (err) {
-      if (err.code === 'ResourceConflictException') {
+      if (err instanceof ResourceConflictException) {
         debug(
           'Lambda function with this configuration already exists. Using existing function.'
         );
@@ -649,7 +651,7 @@ class PlatformLambda {
 
       return res;
     } catch (err) {
-      if (err.name === 'ResourceNotFoundException') {
+      if (err instanceof ResourceNotFoundException) {
         return null;
       }
 

packages/artillery/lib/platform/aws/aws-ensure-s3-bucket-exists.js

@@ -7,7 +7,8 @@ const debug = require('debug')('util:aws:ensureS3BucketExists');
 const {
   S3Client,
   PutBucketLifecycleConfigurationCommand,
-  CreateBucketCommand
+  CreateBucketCommand,
+  NoSuchBucket
 } = require('@aws-sdk/client-s3');
 
 const getAWSAccountId = require('./aws-get-account-id');
@@ -57,7 +58,7 @@ module.exports = async function ensureS3BucketExists(
   try {
     location = await getBucketRegion(bucketName);
   } catch (err) {
-    if (err.name === 'NoSuchBucket') {
+    if (err instanceof NoSuchBucket) {
       await s3.send(new CreateBucketCommand({ Bucket: bucketName }));
     } else {
       throw err;