Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: amazon-ion/ion-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: amazon-ion/ion-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cmake-hacking
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Nov 20, 2023

  1. Warn on ImportError when importing ionc 

    Before this change an ImportError other than ModuleNotFound would
cause an exception to propagate on import that prevented users
from using simpleion at all.

I've seen reports of two different users encountering this error
for two different reasons, and am confident this would fix both.

closes #300
    @rmarrowstone
    rmarrowstone committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    e29a3cd View commit details
    Browse the repository at this point in the history

  2. Initial CMakeLists.txt Files 

    This commit adds CMakeLists.txt files for the overall ion-python
project and the python c-extension.

It allows one to build the c-extension as a  project (assuming
submodules are init'ed and updated) using cmake. Which is what CLion
expects. What is built is not currently loadable by a Python Interpreter.

On it's own this isn't really impactful. But it could be used as part
of a setup for a "Python Interpreter Free" test/debug/profiling setup.

Or... there may be merit in using something like py-build-cmake to
make the project PEP 517 compliant with a pyproject.toml file. I
haven't looked to hard at that, but I think there is an opportunity
there.

I had to add prefixes to the imports in the _ioncmodule.h file to make
it work. That may or may not be the right answer.
    @rmarrowstone
    rmarrowstone committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    59d43c5 View commit details
    Browse the repository at this point in the history
Loading