Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: agronholm/sqlacodegen
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: alloytech/sqlacodegen
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.1.0-with-proxity
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 1 file changed
  • 4 contributors

Commits on May 7, 2020

  1. Add table proxy for Tables

    @aahung
    aahung committed May 7, 2020
    Configuration menu
    Copy the full SHA
    b5d7181 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2020

  1. Fake table.c type [credit: @emulbreh]

    @aahung
    aahung committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    fc3a3b1 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from alloytech/samliu/2.1.0-with-proxity 

    Fake table.c type [credit: @emulbreh]
    @sam-alloy
    sam-alloy authored Jun 24, 2020
    Configuration menu
    Copy the full SHA
    bb692dd View commit details
    Browse the repository at this point in the history

  3. Fake table.c.values() type: List[Column]

    @aahung
    aahung committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    fb09363 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #2 from alloytech/samliu/fake-c.values 

    Fake table.c.values() type: List[Column]
    @sam-alloy
    sam-alloy authored Jun 24, 2020
    Configuration menu
    Copy the full SHA
    5438ddb View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. Revert "Fake table.c.values() type: List[Column]" 

    Using .values() is unsafe, as a new column added to roardata
will implicitly get referenced by calls to .values() even if
roardata hasn't otherwise been changed to use the column.

This means that safely deploying a migration to a table used
in roardata is very inconvenient, unless it can be guaranteed
to go out in an all-deploy.

This reverts commit fb09363.
    @dsgkirkby
    dsgkirkby committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    f52b3b9 View commit details
    Browse the repository at this point in the history

  2. Ensure reliable model order and exclude schema_version

    @dsgkirkby
    dsgkirkby committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    1f45a59 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2020

  1. Make sure columns are in alphabetic order

    @aahung @sam-alloy
    aahung authored and sam-alloy committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    7715231 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2021

  1. avoid missing attribute crash 

    Added a column to partner table and tested using `o r codegen`.

This code path doesn't seem necessary
    Matthew Gill committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    6d8a0ef View commit details
    Browse the repository at this point in the history
Loading