Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/google-cloud-ruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: abedolinger/google-cloud-ruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 2 files changed
  • 1 contributor

Commits on Jun 19, 2019

  1. Cloud Text-to-Speech: changed mode of File.open 

    New: `File.open(filename, "wb") do |file|`
Old:  `File.open(filename, "w") do |file|` 
The audio file needs to be opened as binary, or it will crash with
`Encoding::UndefinedConversionError ("\xFF" from ASCII-8BIT to UTF-8)`
Using Ruby 2.6.1.
    @abedolinger
    abedolinger authored Jun 19, 2019
    Configuration menu
    Copy the full SHA
    0091700 View commit details
    Browse the repository at this point in the history

  2. TTS example edit per owner 

    This version of the Ruby TTS example comes from the product docs, and has been pending an update.
    @abedolinger
    abedolinger authored Jun 19, 2019
    Configuration menu
    Copy the full SHA
    d39d78c View commit details
    Browse the repository at this point in the history

  3. Adding File.open example line to quickstart 

    A first-time user may not know that the `response` object's `audio_content` method is the path to get the response into a file.  It's natural to output to an MP3, since the example response is encoded that way.
    @abedolinger
    abedolinger authored Jun 19, 2019
    Configuration menu
    Copy the full SHA
    040022b View commit details
    Browse the repository at this point in the history

  4. Revert change

    @abedolinger
    abedolinger authored Jun 19, 2019
    Configuration menu
    Copy the full SHA
    78661bf View commit details
    Browse the repository at this point in the history

  5. Added require for the gem

    @abedolinger
    abedolinger authored Jun 19, 2019
    Configuration menu
    Copy the full SHA
    c7d0c08 View commit details
    Browse the repository at this point in the history

  6. Add File.open to quickstart example 

    Currently, the `response` object in the example is only stored in memory. It's not self-evident that the `response`'s `audio_content` method is the way to work with the audio.  Since the example is encoded as an MP3, I think it's natural to show the first-time user how to save that file to disk, and introduce them to that method.
    @abedolinger
    abedolinger authored Jun 19, 2019
    Configuration menu
    Copy the full SHA
    fb12245 View commit details
    Browse the repository at this point in the history
Loading