Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 4 commits
- 2 files changed
- 2 contributors
Commits on Feb 2, 2021
-
Implement return type and parameter type on the Rewrite file
In this case, when implementing this extension on the latest magento version 2.3.6-p1 and with PHP 7.3 the rewrite function does return the CookieMetadata as the parent function does: vendor/magento/framework/Stdlib/Cookie/CookieMetadata.php:157 In this commit the correct parameter type is added as well as the correct return type
Commits on Feb 15, 2021
-
Merge pull request #24 from cstergianos/feature/fix-return-parameters…
…-type Implement return type and parameter type on the Rewrite file
-
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...2.x-develop