-
-
Notifications
You must be signed in to change notification settings - Fork 155
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: DataTables/Buttons
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: MuellerMatthew/Buttons
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 12 commits
- 2 files changed
- 1 contributor
Commits on Sep 18, 2015
-
Preventing the reordering of columns from replacing the `<span> tags in normal datatables styling or the `<a> tags used on each button if using bootstrap styling. This patch fixes the first part of #26.
Configuration menu - View commit details
-
Copy full SHA for a9de92e - Browse repository at this point
Copy the full SHA a9de92eView commit details
Commits on Sep 21, 2015
-
appending the popup information box to the table instead of the html body so it always opens above the table.
Configuration menu - View commit details
-
Copy full SHA for 2e636d4 - Browse repository at this point
Copy the full SHA 2e636d4View commit details -
Updating logic to check for children elements.
Configuration menu - View commit details
-
Copy full SHA for 75109f0 - Browse repository at this point
Copy the full SHA 75109f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80df189 - Browse repository at this point
Copy the full SHA 80df189View commit details
Commits on Sep 22, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 52bda95 - Browse repository at this point
Copy the full SHA 52bda95View commit details -
Configuration menu - View commit details
-
Copy full SHA for f701488 - Browse repository at this point
Copy the full SHA f701488View commit details -
Merge pull request #3 from MuellerMatthew/patch-2
Update dataTables.buttons.js
Configuration menu - View commit details
-
Copy full SHA for 460b9d9 - Browse repository at this point
Copy the full SHA 460b9d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e05a169 - Browse repository at this point
Copy the full SHA e05a169View commit details -
Updated to allow users to customize column headers when exporting.
I have been playing around with the export features today, and I came up with several minor improvements which I think enhance the functionality of the buttons export feature by allowing users to customized how both the data and the headers are exported. The first change I recommend(but am not submitting as part of this request) is to change the default orthogonal type from 'display' to 'export' and add a note to the documentation that the buttons function extends the orthogonal types used by the ColumnDefs render so that people can pre-process the data with special formatting, characters, etc when exporting the data. Secondly, and this is where my new pull request fits in. It would be nice to also be able to customize the column headers when exporting the data. Currently the export function just uses the existing column headers which are shown on the table when exporting. This pull request adds a configuration option to the exportOptions called "columnHeaders" which defaults to the current setup and just returns the column headers, but which can be configured by passing a function which will recieve the existing column headers and which can then return a processed version of the headers. This is useful for internationalization where you want to change the language used in the titles, as well as when you are exporting data which needs to be formatted in a particular way for another application to properly read it.
Configuration menu - View commit details
-
Copy full SHA for 6c49cc8 - Browse repository at this point
Copy the full SHA 6c49cc8View commit details
Commits on Sep 23, 2015
-
updated function to accept individual columns as input
I updated the function, and applied it to the footers also. The function is now called for each column which is being exported and it is passed 3 values. The 'colnum' is the column number where the data is from, the 'title' is the existing display title and the default response, and the 'column' is the column object. Whatever string/value is returned from the function after the function runs is then used to populate the column header/footer. If someone creates their own parse function for the column headers they can use the columnHeaders config setting to replace the default function with their custom function to custom parse the header data.
Configuration menu - View commit details
-
Copy full SHA for a0cfda6 - Browse repository at this point
Copy the full SHA a0cfda6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e6b39c - Browse repository at this point
Copy the full SHA 7e6b39cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5103d52 - Browse repository at this point
Copy the full SHA 5103d52View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master