Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: DataTables/Buttons
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: MuellerMatthew/Buttons
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 12 commits
  • 2 files changed
  • 1 contributor

Commits on Sep 18, 2015

  1. Update buttons.colVis.js

    Preventing the reordering of columns from replacing the `<span> tags in normal datatables styling or the  `<a> tags used on each button if using bootstrap styling.  This patch fixes the first part of #26.
    MuellerMatthew committed Sep 18, 2015
    Configuration menu
    Copy the full SHA
    a9de92e View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2015

  1. Update dataTables.buttons.js

    appending the popup information box to the table instead of the html body so it always opens above the table.
    MuellerMatthew committed Sep 21, 2015
    Configuration menu
    Copy the full SHA
    2e636d4 View commit details
    Browse the repository at this point in the history
  2. Update buttons.colVis.js

    Updating logic to check for children elements.
    MuellerMatthew committed Sep 21, 2015
    Configuration menu
    Copy the full SHA
    75109f0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    80df189 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2015

  1. Merge pull request #1 from DataTables/master

    updating fork
    MuellerMatthew committed Sep 22, 2015
    Configuration menu
    Copy the full SHA
    52bda95 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f701488 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #3 from MuellerMatthew/patch-2

    Update dataTables.buttons.js
    MuellerMatthew committed Sep 22, 2015
    Configuration menu
    Copy the full SHA
    460b9d9 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #4 from DataTables/master

    updating
    MuellerMatthew committed Sep 22, 2015
    Configuration menu
    Copy the full SHA
    e05a169 View commit details
    Browse the repository at this point in the history
  5. Updated to allow users to customize column headers when exporting.

    I have been playing around with the export features today, and I came up with several minor improvements which I think enhance the functionality of the buttons export feature by allowing users to customized how both the data and the headers are exported.  
    
    The first change I recommend(but am not submitting as part of this request) is to change the default orthogonal type from 'display' to 'export' and add a note to the documentation that the buttons function extends the orthogonal types used by the ColumnDefs render so that people can pre-process the data with special formatting, characters, etc when exporting the data.
    
    Secondly, and this is where my new pull request fits in. It would be nice to also be able to customize the column headers when exporting the data.  Currently the export function just uses the existing column headers which are shown on the table when exporting.  This pull request adds a configuration option to the exportOptions called "columnHeaders" which defaults to the current setup and just returns the column headers, but which can be configured by passing a function which will recieve the existing column headers and which can then return a processed version of the headers.  This is useful for internationalization where you want to change the language used in the titles, as well as when you are exporting data which needs to be formatted in a particular way for another application to properly read it.
    MuellerMatthew committed Sep 22, 2015
    Configuration menu
    Copy the full SHA
    6c49cc8 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2015

  1. updated function to accept individual columns as input

    I updated the function, and applied it to the footers also.  
    
    The function is now called for each column which is being exported and it is passed 3 values.  The 'colnum' is the column number where the data is from, the 'title' is the existing display title and the default response, and the 'column' is the column object.  Whatever string/value is returned from the function after the function runs is then used to populate the column header/footer.
    
    If someone creates their own parse function for the column headers they can use the columnHeaders config setting to replace the default function with their custom function to custom parse the header data.
    MuellerMatthew committed Sep 23, 2015
    Configuration menu
    Copy the full SHA
    a0cfda6 View commit details
    Browse the repository at this point in the history
  2. fixed bug

    MuellerMatthew committed Sep 23, 2015
    Configuration menu
    Copy the full SHA
    7e6b39c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5103d52 View commit details
    Browse the repository at this point in the history
Loading