Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: LineageOS/android_frameworks_base
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: lineage-15.1
Choose a base ref
...
head repository: MemeUI/android_frameworks_base
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: lineage-15.1
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 5 files changed
  • 2 contributors

Commits on Jan 3, 2020

  1. Better, consistent definition of AID_SHARED_GID. 

    AID_SHARED_GID is a GID shared by a specific app across all users on
the same device.  Bring the UserHandle and multiuser.c implementations
into agreement, and copy/paste the unit tests that verify that both
behave identically.

Since we might now return "-1" when a GID is invalid, have
ActivityManager handle these cases by quickly swapping in the
always-valid getUserGid().

Test: bit FrameworksCoreTests:android.os.UserHandleTest
Bug: 34151068, 64548938
Change-Id: I0463aba923ae5ce1942666359a394ae6cdb7c1f8
    @jsharkey @Thespartann
    jsharkey authored and Thespartann committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    f2239b6 View commit details
    Browse the repository at this point in the history

  2. Fix package install flow w.r.t. dexopt 

    Calling dexopt before the applicationInfo gets the uid is wrong.
Dexopt needs to be able to set the GID of the odex file to the
UserHandle.getSharedAppGid(pkg.applicationInfo.uid) and that is
possible only with a valid uid.

Move the dexopt logic after installNewPackageLIF/replacePackageLIF
to ensure that we get a valid uid.

Bug: 69331247
Test: adb install & check the GID of the compiler artifacts

(cherry picked from commit c6540da)

Merged-In: I2434a1a0b9015091a9af2009b3f785b7a16e1256
Change-Id: I2434a1a0b9015091a9af2009b3f785b7a16e1256
    @Thespartann
    Calin Juravle authored and Thespartann committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    46362b0 View commit details
    Browse the repository at this point in the history
Loading