From afae58a835c8cf611bdfcbb256c36adfdd1611b4 Mon Sep 17 00:00:00 2001 From: Nicolas Fukuyama Date: Mon, 6 Jan 2025 10:40:25 -0300 Subject: [PATCH 1/6] CU-86c1h04qk publish package to github --- .github/workflows/publish.yml | 34 ++++++++++++++++++++++++++++++++++ package.json | 5 ++++- 2 files changed, 38 insertions(+), 1 deletion(-) create mode 100644 .github/workflows/publish.yml diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml new file mode 100644 index 0000000..419b0b7 --- /dev/null +++ b/.github/workflows/publish.yml @@ -0,0 +1,34 @@ +name: Publish Package to npm +on: + workflow_dispatch: + inputs: + tag: + description: "Package tag" + required: false + type: string + push: + branches: + - master +jobs: + publish: + permissions: + packages: write + pull-requests: write + + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 + with: + node-version: "22.x" + registry-url: "https://npm.pkg.github.com" + scope: "@kittl" + - name: Get pnpm store directory + shell: bash + run: | + echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV + - name: Install package dependencies + run: pnpm install --frozen-lockfile + + - name: Build package + run: npm publish diff --git a/package.json b/package.json index 325a3dd..2d010bd 100644 --- a/package.json +++ b/package.json @@ -74,5 +74,8 @@ "dependencies": { "node-abort-controller": "^3.0.1" }, - "type": "module" + "type": "module", + "publishConfig": { + "registry": "https://npm.pkg.github.com" + } } From cc2d6ba8342fd87eaed1a088ea0c4766b9a00821 Mon Sep 17 00:00:00 2001 From: Nicolas Fukuyama Date: Mon, 6 Jan 2025 11:00:30 -0300 Subject: [PATCH 2/6] run publish on pr --- .github/workflows/publish.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 419b0b7..54bd127 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -9,6 +9,7 @@ on: push: branches: - master + - "CU-86c1h04qk-npm-auth" jobs: publish: permissions: From efb9f6717af1eb4b61337aa00a971ff978c0d510 Mon Sep 17 00:00:00 2001 From: Nicolas Fukuyama Date: Mon, 6 Jan 2025 11:01:21 -0300 Subject: [PATCH 3/6] remove pnpm config --- .github/workflows/publish.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 54bd127..d9e3f01 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -24,12 +24,8 @@ jobs: node-version: "22.x" registry-url: "https://npm.pkg.github.com" scope: "@kittl" - - name: Get pnpm store directory - shell: bash - run: | - echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV - name: Install package dependencies - run: pnpm install --frozen-lockfile + run: npm install --frozen-lockfile - name: Build package run: npm publish From a69245d417ca44687177e006d0ccdea974799780 Mon Sep 17 00:00:00 2001 From: Nicolas Fukuyama Date: Mon, 6 Jan 2025 11:05:52 -0300 Subject: [PATCH 4/6] add npm token --- .github/workflows/publish.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index d9e3f01..f2d16f0 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -15,6 +15,8 @@ jobs: permissions: packages: write pull-requests: write + contents: read + id-token: write runs-on: ubuntu-latest steps: @@ -29,3 +31,5 @@ jobs: - name: Build package run: npm publish + env: + NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} From b3753d227092a55ca6e987886a52a4194a484dc7 Mon Sep 17 00:00:00 2001 From: Nicolas Fukuyama Date: Mon, 6 Jan 2025 11:43:09 -0300 Subject: [PATCH 5/6] chore(CU-86c1h04qk): update package to publish on github registry --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 2d010bd..1165f87 100644 --- a/package.json +++ b/package.json @@ -1,5 +1,5 @@ { - "name": "@kittl/redlock", + "name": "@kittl/node-redlock", "version": "5.0.0-beta.3", "description": "A node.js redlock implementation for distributed redis locks", "license": "MIT", @@ -9,7 +9,7 @@ }, "repository": { "type": "git", - "url": "git+https://github.com/kittl/node-redlock.git" + "url": "https://github.com/kittl/node-redlock.git" }, "homepage": "https://github.com/kittl/node-redlock#readme", "bugs": "https://github.com/kittl/node-redlock/issues", From d15c682d42a0e170585f23a015ce7b05cb1f3358 Mon Sep 17 00:00:00 2001 From: Nicolas Fukuyama Date: Mon, 6 Jan 2025 11:44:22 -0300 Subject: [PATCH 6/6] remove publish workflow --- .github/workflows/publish.yml | 35 ----------------------------------- 1 file changed, 35 deletions(-) delete mode 100644 .github/workflows/publish.yml diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml deleted file mode 100644 index f2d16f0..0000000 --- a/.github/workflows/publish.yml +++ /dev/null @@ -1,35 +0,0 @@ -name: Publish Package to npm -on: - workflow_dispatch: - inputs: - tag: - description: "Package tag" - required: false - type: string - push: - branches: - - master - - "CU-86c1h04qk-npm-auth" -jobs: - publish: - permissions: - packages: write - pull-requests: write - contents: read - id-token: write - - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - uses: actions/setup-node@v4 - with: - node-version: "22.x" - registry-url: "https://npm.pkg.github.com" - scope: "@kittl" - - name: Install package dependencies - run: npm install --frozen-lockfile - - - name: Build package - run: npm publish - env: - NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}