Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: shaubert/android-process-button
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: JonathanBaby/android-process-button
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 17 commits
  • 32 files changed
  • 1 contributor

Commits on Oct 26, 2015

  1. Updated Gradle Android tools from 1.2.3 to 1.3.0

    @JonathanBaby
    JonathanBaby committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    3476e5f View commit details
    Browse the repository at this point in the history

  2. Removed shadow shape on normal state, looks more Material Design

    @JonathanBaby
    JonathanBaby committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    588080d View commit details
    Browse the repository at this point in the history

  3. Replaced explicit "48dp" layout_height with "wrap_content" 

    As 48dp is the default Android button height... or close.
    @JonathanBaby
    JonathanBaby committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    bc3f118 View commit details
    Browse the repository at this point in the history

  4. Upgraded Gradle tools & Android SDK versions + AppCompatActivity

    @JonathanBaby
    JonathanBaby committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    fbd277a View commit details
    Browse the repository at this point in the history

  5. Removed useless themes on Activities in AndroidManifest

    @JonathanBaby
    JonathanBaby committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    b2fc6d1 View commit details
    Browse the repository at this point in the history

  6. Replaced Holo with Material theme, using AppCompat

    @JonathanBaby
    JonathanBaby committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    89fb7dd View commit details
    Browse the repository at this point in the history

  7. Replaced explicit "48dp" layout_height with "wrap_content" (further) 

    As 48dp is the default Android button height... or close.
    @JonathanBaby
    JonathanBaby committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    976b820 View commit details
    Browse the repository at this point in the history

  8. Added buttons to play with enabled/disabled states

    @JonathanBaby
    JonathanBaby committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    498bf2a View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2015

  1. Fixed ripple getting out of bounds on normal state, using rounded mask

    @JonathanBaby
    JonathanBaby committed Oct 28, 2015
    Configuration menu
    Copy the full SHA
    63092cd View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2015

  1. Adapt smoothProgressBar width to cornerRadius

    @JonathanBaby
    JonathanBaby committed Oct 29, 2015
    Configuration menu
    Copy the full SHA
    0d8a06f View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2015

  1. Used clipToPadding="false" attributes to not clip material shadows 

    + fixed ToogleButton height in ac_message.xml
    @JonathanBaby
    JonathanBaby committed Oct 30, 2015
    Configuration menu
    Copy the full SHA
    5fc78ec View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2015

  1. Replaced StateListDrawable using tint ColorStateList 

    1. Avoids the costs of creating multiple Drawables for each state
2. tint, as opposed to setColor/setBackgroundColor, does not instanciate
a new Drawable in memory (performance pattern evoked by Nick Tkachov
here: https://youtu.be/71ISWyJPSEY?t=21m37s)
    @JonathanBaby
    JonathanBaby committed Oct 31, 2015
    Configuration menu
    Copy the full SHA
    dae4581 View commit details
    Browse the repository at this point in the history

  2. Added DrawableUtils for static methods from BackgroundBuilder

    @JonathanBaby
    JonathanBaby committed Oct 31, 2015
    Configuration menu
    Copy the full SHA
    dcf9b9c View commit details
    Browse the repository at this point in the history

  3. Removed unused dimen.xml

    @JonathanBaby
    JonathanBaby committed Oct 31, 2015
    Configuration menu
    Copy the full SHA
    a39a217 View commit details
    Browse the repository at this point in the history

  4. Renamed state colors to keep state qualifiers only

    @JonathanBaby
    JonathanBaby committed Oct 31, 2015
    Configuration menu
    Copy the full SHA
    7b5cb2a View commit details
    Browse the repository at this point in the history

  5. Added pb_colorFocused XML attribute to FlatButton

    @JonathanBaby
    JonathanBaby committed Oct 31, 2015
    Configuration menu
    Copy the full SHA
    b7992ea View commit details
    Browse the repository at this point in the history

  6. Merge XML attributes with default tint ColorStateList

    @JonathanBaby
    JonathanBaby committed Oct 31, 2015
    Configuration menu
    Copy the full SHA
    4cd0a62 View commit details
    Browse the repository at this point in the history
Loading