Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: libssh2/libssh2
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Hdom/libssh2
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 2 files changed
  • 3 contributors

Commits on Feb 9, 2020

  1. wincng: use newer DH API for Windows 8.1+ 

    Since Windows 1903 the approach used to perform DH kex with the CNG
API has been failing.

This commit switches to using the `DH` algorithm provider to perform
generation of the key pair and derivation of the shared secret.

It uses a feature of CNG that is not yet documented.  The sources of
information that I've found on this are:

* https://stackoverflow.com/a/56378698/149111
* https://github.com/wbenny/mini-tor/blob/5d39011e632be8e2b6b1819ee7295e8bd9b7a769/mini/crypto/cng/dh.inl#L355

With this change I am able to successfully connect from Windows 10 to my
ubuntu system.

Fixes: #388
Refs: alexcrichton/ssh2-rs#122
    @wez
    wez committed Feb 9, 2020
    Configuration menu
    Copy the full SHA
    2d1e022 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. Merge pull request #1 from wez/win10pr 

    wincng: use newer DH API for Windows 8.1+
    @Hdom
    Hdom authored Feb 27, 2020
    Configuration menu
    Copy the full SHA
    04b3c0f View commit details
    Browse the repository at this point in the history

  2. Altering RtlGetVersion usage and generation

    Dennys Orozco committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    d9e992e View commit details
    Browse the repository at this point in the history
Loading