Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: intothefire/ruby-postcodeanywhere
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: FundingCircle/ruby-postcodeanywhere
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 16 files changed
  • 3 contributors

Commits on Apr 19, 2023

  1. change code owners to apply team

    @arcaartem
    arcaartem committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    2e17f5e View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Merge pull request #11 from FundingCircle/tlp-3496 

    [TLP-3496] - Change code owners to Apply Team
    @arcaartem
    arcaartem authored Apr 20, 2023
    Configuration menu
    Copy the full SHA
    6634f4c View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Run rubocop and cleanup the code a bit 

    This is done with ruby 2.5.9
    @bliof-fc
    bliof-fc committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    7e161fd View commit details
    Browse the repository at this point in the history

  2. Add some basic ci

    @bliof-fc
    bliof-fc committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    09d64de View commit details
    Browse the repository at this point in the history

  3. Update rspec and fix rubocop

    @bliof-fc
    bliof-fc committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    e7a8d56 View commit details
    Browse the repository at this point in the history

  4. Update httparty 

    Newer versions of httparty add `/` at the end of the base_uri so it is
better to always specify a path when we do `.get`.

When we do `.get('', ...)`, the new httparty was doing

```
https://services.postcodeanywhere.co.uk/BankAccountValidation/Interactive/Validate/v2.00/json3.ws/?Key=
```

but we want

```
https://services.postcodeanywhere.co.uk/BankAccountValidation/Interactive/Validate/v2.00/json3.ws?Key=
```
    @bliof-fc
    bliof-fc committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    ff25ccd View commit details
    Browse the repository at this point in the history

  5. Bump version to 0.2.0 and gemspec 

    Updating all gems and removing unneeded dependencies.
    @bliof-fc
    bliof-fc committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    2cee335 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #10 from FundingCircle/update-a-bit 

    Update a bit
    @bliof-fc
    bliof-fc authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    441e5cc View commit details
    Browse the repository at this point in the history
Loading