Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: DEfusion/screencap
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Eventshare/screencap
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 3 files changed
  • 1 contributor

Commits on Feb 23, 2016

  1. Ignore .idea.

    Jeremy Kallman committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    cf5bf50 View commit details
    Browse the repository at this point in the history
  2. Fix for div not found when it hasn’t rendered yet.

    Happens when div loading is dependent on resources loading.
    Jeremy Kallman committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    64214bc View commit details
    Browse the repository at this point in the history
  3. Bump version.

    Jeremy Kallman committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    376bb70 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2016

  1. Fix for not capturing with a height arg correctly.

    - Instead of modifying the height of the body (and html) after render we
      just set the mask to take care of it. The image we were getting was of
      the full size page cropped down to the height and the rest filled with
      white. I think this is because the larger initial page size caused the
      viewport to expand but then it didn’t contract.
    
    - Since args.div will supersede the mask eventually, don’t set the mask
      up front if args.div is present. Set the mask solely on the height arg
      as we can default top and left to 0.
    
    This fixes the failing unit tests when running locally.
    Jeremy Kallman committed Apr 1, 2016
    Configuration menu
    Copy the full SHA
    0478476 View commit details
    Browse the repository at this point in the history
Loading