World flag in manuaddp

[Jrud]

We server admins like to create discoverable worldguard regions on our server, so that once the user enters them, they get a permanent permission for a warp to that place using a combination of group manager, world guard, and world guard extra flags, this works pretty well, however there is a small concern because the group manager commands to select the world, and then add the permission for the warp are separate, so there is a small chance that another player could enter a region in another world at the same time, and the discovery would not work.

It would be useful in this, and other circumstances to have a world flag option in the manuaddp command for specifying which world to add the permission for without the need to select the world in question first.

[ElgarL]

You shouldn't need to use the '/manselect [word]' as it will default to the world the player is currently in.
If you don't use manselect it won't have a forced world.

[Octol1ttle]

It would be useful in this, and other circumstances to have a world flag option in the manuaddp command for specifying which world to add the permission for without the need to select the world in question first.

That would need a change on how arguments are parsed (I still didn't find a way to support multiple permissions in 1 command and support a world argument) and a change on how permissions are added.
In my opinion, it's too much work to do when everything that's required from you is typing 1 more command.

[Jrud]

You shouldn't need to use the '/manselect [word]' as it will default to the world the player is currently in.
If you don't use manselect it won't have a forced world.

Oh that's interesting. I do have some other features on my server however that I do need to switch between a few worlds for, such as when people select their race when they first join, the server rolls through some world groups and adds the player to the correct groups for some special perms in them. After these are complete, how do I clear my selected world so it goes back to this default behavior?

[Jrud]

That would need a change on how arguments are parsed (I still didn't find a way to support multiple permissions in 1 command and support a world argument) and a change on how permissions are added.
In my opinion, it's too much work to do when everything that's required from you is typing 1 more command.

I can appreciate that, I'm a dev too, just not the java kind. If minecraft were written in C#, I would be all over it haha.

I don't have a problem manually typing the command when I have to, it's that it makes your plugin slightly less reliable in combination with my other plugins if a couple of different events that require a world selection happen at the same time.

If it's too difficult to add optional parameters, then would it be easier to create a copy of the command and add a little new syntax for a static variable list? Like /manuaddpw

[Octol1ttle]

then would it be easier to create a copy of the command and add a little new syntax for a static variable list? Like /manuaddpw

1. I don't think it's a good idea to add a separate command that is basically manuaddp but with 1 more argument
2. It would still call for the same method (addPermission) as manuaddp (unless we implement a new method just for world support, but I don't think that's a good idea either)

It's not a bad idea to add a world argument. If someone PRs it, I would accept it (the decision to merge is still up to ElgarL)

After these are complete, how do I clear my selected world so it goes back to this default behavior?

/manclear

[ElgarL]

I've been thinking about this some more and WG flags should be running the commands in a single tick so nothing else should be able to jump in between a manselect, assign permission and manclear

[Jrud]

I've been thinking about this some more and WG flags should be running the commands in a single tick so nothing else should be able to jump in between a manselect, assign permission and manclear

Unfortunately, there's also a problem with WorldGuard Extra Flags plugin that doesn't let you change the order in which the commands are run :(. I put in a feature request for that for them as well.

[Jrud]

It's not a bad idea to add a world argument. If someone PRs it, I would accept it (the decision to merge is still up to ElgarL)

Does that mean you'd add it if someone payrolls it? or promotes it? I'm not sure what PR stands for.

[Octol1ttle]

PR - pull request

[Jrud]

PR - pull request

oh yeah, git hub has pull requests... sorry, I use TFS and there is no such thing there. If I get a crazy amount of free time to play with java again in the future I'll consider it.